Skip to content

BLD: rename some extensions #15532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Conversation

jreback
Copy link
Contributor

@jreback jreback commented Feb 28, 2017

xref #12588

This is a move (and deprecation of json/parser) of pandas.json, pandas.parser,

also moves some extensions into the main structure as appropriate

renames extensions to follow the pattern "libxxx" for consistency (as well as some renaming of the .pyx files themselves). In effect locates the library code next to the calling code.

@jreback jreback added the Build Library building on various platforms label Feb 28, 2017
@jreback jreback added this to the 0.20.0 milestone Feb 28, 2017
xref pandas-dev#12588

pandas.parser -> io/libparsers.pyx

pandas.json -> pandas.io.json.libjson

pandas.io.sas.saslib -> libsas

pandas.msgpack -> pandas.io.msgpack
@codecov-io
Copy link

codecov-io commented Mar 1, 2017

Codecov Report

Merging #15532 into master will decrease coverage by -0.04%.
The diff coverage is 92.59%.

@@            Coverage Diff             @@
##           master   #15532      +/-   ##
==========================================
- Coverage   91.06%   91.03%   -0.04%     
==========================================
  Files         136      139       +3     
  Lines       49099    49120      +21     
==========================================
+ Hits        44714    44718       +4     
- Misses       4385     4402      +17
Impacted Files Coverage Δ
pandas/io/msgpack/_version.py 100% <ø> (ø)
pandas/io/msgpack/exceptions.py 83.33% <ø> (ø)
pandas/compat/pickle_compat.py 68.29% <ø> (ø)
pandas/json.py 100% <100%> (ø)
pandas/io/msgpack/init.py 79.16% <100%> (ø)
pandas/core/reshape.py 99.25% <100%> (ø)
pandas/io/sas/init.py 100% <100%> (ø)
pandas/io/excel.py 79.64% <100%> (ø)
pandas/util/testing.py 82.06% <100%> (ø)
pandas/init.py 92.3% <100%> (+0.64%)
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0a281f...afa606f. Read the comment docs.

@jreback
Copy link
Contributor Author

jreback commented Mar 1, 2017

closing in favor of #15537 which does it all.

@jreback jreback closed this Mar 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Library building on various platforms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants