Skip to content

CLN: hide all imported extensions #12588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jreback opened this issue Mar 11, 2016 · 1 comment
Closed

CLN: hide all imported extensions #12588

jreback opened this issue Mar 11, 2016 · 1 comment
Labels
Build Library building on various platforms Compat pandas objects compatability with Numpy or Python functions
Milestone
0.20.0

Comments

@jreback
Copy link
Contributor

jreback commented Mar 11, 2016

so most of these are in the top-level namespace, so let's rename to use _ leading if not already like that.

e.g. _lib rather than lib

just requires some small changes in setup.py, but a fair number of imports need to be changed.
This is a slight API change, in that people could be relying upon it. So we could create a deprecation warning if these names are accessed (and then have it work).

~/pandas]$ find pandas -name '*.so'
pandas/_period.so
pandas/_sparse.so
pandas/_testing.so
pandas/algos.so
pandas/hashtable.so
pandas/index.so
pandas/io/sas/saslib.so
pandas/json.so
pandas/lib.so
pandas/msgpack/_packer.so
pandas/msgpack/_unpacker.so
pandas/parser.so
pandas/tslib.so
@jreback jreback added Build Library building on various platforms Compat pandas objects compatability with Numpy or Python functions labels Mar 11, 2016
@jreback jreback added this to the 0.18.1 milestone Mar 11, 2016
@jreback jreback modified the milestones: 0.18.1, Next Major Release Apr 25, 2016
@jreback jreback mentioned this issue Feb 28, 2017
Closed
jreback added a commit to jreback/pandas that referenced this issue Feb 28, 2017
@jreback
BLD: make all extensions private
81ad65d 
closes pandas-dev#12588
jreback added a commit to jreback/pandas that referenced this issue Feb 28, 2017
@jreback
BLD: rename / move some extensions
f9dcad7 
xref pandas-dev#12588

pandas.parser -> io/libparsers.pyx

pandas.json -> pandas.io.json.libjson

pandas.io.sas.saslib -> libsas

pandas.msgpack -> pandas.io.msgpack
jreback added a commit to jreback/pandas that referenced this issue Mar 1, 2017
@jreback
BLD: rename / move some extensions
275b40b 
xref pandas-dev#12588

pandas.parser -> io/libparsers.pyx

pandas.json -> pandas.io.json.libjson

pandas.io.sas.saslib -> libsas

pandas.msgpack -> pandas.io.msgpack
jreback added a commit to jreback/pandas that referenced this issue Mar 2, 2017
@jreback
BLD: rename / move some extensions
addefa0 
xref pandas-dev#12588

pandas.parser -> io/libparsers.pyx
pandas.json -> pandas.io.json.libjson
pandas.io.sas.saslib -> libsas
pandas.msgpack -> pandas.io.msgpack
pandas._testing -> pandas.util.libtesting
pandas._sparse -> pandas.sparse.libsparse
pandas._hash -> pandas.tools.libhash
pandas.tslib -> pandas.libs.tslib
pandas.index -> pandas.libs.index
pandas.algos -> pandas.libs.algos
pandas.lib -> pandas.libs.lib
pandas.hashtable -> pandas.libs.hashtable
pandas._window -> pandas.core.libwindow
pandas._join -> pandas.libs.join
move algos*.in, index*.in, hashtable*.in to libs
pandas._period -> pandas.libs.period
jreback added a commit to jreback/pandas that referenced this issue Mar 2, 2017
@jreback
BLD: rename / move some extensions
5d1d491 
xref pandas-dev#12588

pandas.parser -> io/libparsers.pyx
pandas.json -> pandas.io.json.libjson
pandas.io.sas.saslib -> libsas
pandas.msgpack -> pandas.io.msgpack
pandas._testing -> pandas.util.libtesting
pandas._sparse -> pandas.sparse.libsparse
pandas._hash -> pandas.tools.libhash
pandas.tslib -> pandas.libs.tslib
pandas.index -> pandas.libs.index
pandas.algos -> pandas.libs.algos
pandas.lib -> pandas.libs.lib
pandas.hashtable -> pandas.libs.hashtable
pandas._window -> pandas.core.libwindow
pandas._join -> pandas.libs.join
move algos*.in, index*.in, hashtable*.in to libs
pandas._period -> pandas.libs.period
jreback added a commit to jreback/pandas that referenced this issue Mar 3, 2017
@jreback
BLD: rename / move some extensions
00a7751 
xref pandas-dev#12588

pandas.parser -> io/libparsers.pyx
pandas.json -> pandas.io.json.libjson
pandas.io.sas.saslib -> libsas
pandas.msgpack -> pandas.io.msgpack
pandas._testing -> pandas.util.libtesting
pandas._sparse -> pandas.sparse.libsparse
pandas._hash -> pandas.tools.libhash
pandas.tslib -> pandas.libs.tslib
pandas.index -> pandas.libs.index
pandas.algos -> pandas.libs.algos
pandas.lib -> pandas.libs.lib
pandas.hashtable -> pandas.libs.hashtable
pandas._window -> pandas.core.libwindow
pandas._join -> pandas.libs.join
move algos*.in, index*.in, hashtable*.in to libs
pandas._period -> pandas.libs.period
jreback added a commit to jreback/pandas that referenced this issue Mar 5, 2017
@jreback
BLD: rename / move some extensions
adcbe16 
xref pandas-dev#12588

pandas.parser -> io/libparsers.pyx
pandas.json -> pandas.io.json.libjson
pandas.io.sas.saslib -> libsas
pandas.msgpack -> pandas.io.msgpack
pandas._testing -> pandas.util.libtesting
pandas._sparse -> pandas.sparse.libsparse
pandas._hash -> pandas.tools.libhash
pandas.tslib -> pandas.libs.tslib
pandas.index -> pandas.libs.index
pandas.algos -> pandas.libs.algos
pandas.lib -> pandas.libs.lib
pandas.hashtable -> pandas.libs.hashtable
pandas._window -> pandas.core.libwindow
pandas._join -> pandas.libs.join
move algos*.in, index*.in, hashtable*.in to libs
pandas._period -> pandas.libs.period
jreback added a commit to jreback/pandas that referenced this issue Mar 5, 2017
@jreback
BLD: rename / move some extensions
a23176f 
xref pandas-dev#12588

pandas.parser -> io/libparsers.pyx
pandas.json -> pandas.io.json.libjson
pandas.io.sas.saslib -> libsas
pandas.msgpack -> pandas.io.msgpack
pandas._testing -> pandas.util.libtesting
pandas._sparse -> pandas.sparse.libsparse
pandas._hash -> pandas.tools.libhash
pandas.tslib -> pandas.libs.tslib
pandas.index -> pandas.libs.index
pandas.algos -> pandas.libs.algos
pandas.lib -> pandas.libs.lib
pandas.hashtable -> pandas.libs.hashtable
pandas._window -> pandas.core.libwindow
pandas._join -> pandas.libs.join
move algos*.in, index*.in, hashtable*.in to libs
pandas._period -> pandas.libs.period
jreback added a commit to jreback/pandas that referenced this issue Mar 5, 2017
@jreback
BLD: rename / move some extensions
bec46a7 
xref pandas-dev#12588

pandas.parser -> io/libparsers.pyx
pandas.json -> pandas.io.json.libjson
pandas.io.sas.saslib -> libsas
pandas.msgpack -> pandas.io.msgpack
pandas._testing -> pandas.util.libtesting
pandas._sparse -> pandas.sparse.libsparse
pandas._hash -> pandas.tools.libhash
pandas.tslib -> pandas.libs.tslib
pandas.index -> pandas.libs.index
pandas.algos -> pandas.libs.algos
pandas.lib -> pandas.libs.lib
pandas.hashtable -> pandas.libs.hashtable
pandas._window -> pandas.core.libwindow
pandas._join -> pandas.libs.join
move algos*.in, index*.in, hashtable*.in to libs
pandas._period -> pandas.libs.period
jreback added a commit to jreback/pandas that referenced this issue Mar 7, 2017
@jreback
BLD: rename / move some extensions
44be976 
xref pandas-dev#12588

pandas.parser -> io/libparsers.pyx
pandas.json -> pandas.io.json.libjson
pandas.io.sas.saslib -> libsas
pandas.msgpack -> pandas.io.msgpack
pandas._testing -> pandas.util.libtesting
pandas._sparse -> pandas.sparse.libsparse
pandas._hash -> pandas.tools.libhash
pandas.tslib -> pandas.libs.tslib
pandas.index -> pandas.libs.index
pandas.algos -> pandas.libs.algos
pandas.lib -> pandas.libs.lib
pandas.hashtable -> pandas.libs.hashtable
pandas._window -> pandas.core.libwindow
pandas._join -> pandas.libs.join
move algos*.in, index*.in, hashtable*.in to libs
pandas._period -> pandas.libs.period
jreback added a commit to jreback/pandas that referenced this issue Mar 7, 2017
@jreback
BLD: rename / move some extensions
a6d6cfa 
xref pandas-dev#12588

pandas.parser -> io/libparsers.pyx
pandas.json -> pandas.io.json.libjson
pandas.io.sas.saslib -> libsas
pandas.msgpack -> pandas.io.msgpack
pandas._testing -> pandas.util.libtesting
pandas._sparse -> pandas.sparse.libsparse
pandas._hash -> pandas.tools.libhash
pandas.tslib -> pandas.libs.tslib
pandas.index -> pandas.libs.index
pandas.algos -> pandas.libs.algos
pandas.lib -> pandas.libs.lib
pandas.hashtable -> pandas.libs.hashtable
pandas._window -> pandas.core.libwindow
pandas._join -> pandas.libs.join
move algos*.in, index*.in, hashtable*.in to libs
pandas._period -> pandas.libs.period
@jorisvandenbossche
Copy link
Member

This was closed by #15537 and friends

@jorisvandenbossche jorisvandenbossche modified the milestones: 0.20.0, Next Major Release Apr 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Build Library building on various platforms Compat pandas objects compatability with Numpy or Python functions
Projects
None yet
Milestone
0.20.0
Development

No branches or pull requests
2 participants
@jreback @jorisvandenbossche