Skip to content

DOC: Fix to docstrings of is_type_factory and is_instance_factory #15499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 24, 2017
Merged

DOC: Fix to docstrings of is_type_factory and is_instance_factory #15499

merged 1 commit into from
Feb 24, 2017

Conversation

fumitoh
Copy link
Contributor

@fumitoh fumitoh commented Feb 24, 2017 •
edited
Loading

@codecov-io
Copy link

Codecov Report

Merging #15499 into master will decrease coverage by -0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #15499      +/-   ##
==========================================
- Coverage   90.36%   90.36%   -0.01%     
==========================================
  Files         136      136              
  Lines       49532    49532              
==========================================
- Hits        44760    44759       -1     
- Misses       4772     4773       +1
Impacted Files Coverage Δ
pandas/core/config.py 88.09% <ø> (ø) ✅
pandas/core/common.py 91.02% <ø> (-0.34%) ❌

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81c57e2...678195f. Read the comment docs.

@jreback jreback added the Docs label Feb 24, 2017
@jreback jreback added this to the 0.20.0 milestone Feb 24, 2017
@jreback jreback merged commit 924c166 into pandas-dev:master Feb 24, 2017
@jreback
Copy link
Contributor

jreback commented Feb 24, 2017

thanks!

@fumitoh fumitoh deleted the fix-config-docstrings branch February 25, 2017 04:40
AnkurDedania pushed a commit to AnkurDedania/pandas that referenced this pull request Mar 21, 2017
@fumitoh @AnkurDedania
DOC: Fix to docstrings of is_type_factory and is_instance_factory (pa…
f8c5a24 
…ndas-dev#15499)

Closes pandas-dev#15485
johannes-mueller added a commit to boschresearch/pandas that referenced this pull request Nov 16, 2021
@johannes-mueller
BUG: fix get_indexer_non_unique() with 'object' targets with NaNs (pa…
75ff6b0 
…ndas-dev#44482)

numpy.searchsorted() does not handle NaNs in 'object' arrays as
expected (numpy/numpy/pandas-dev#15499).  Therefore we cannot search NaNs using binary
search.  So we use binary search only for targets without NaNs.
@johannes-mueller johannes-mueller mentioned this pull request Nov 16, 2021
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Docs
Projects
None yet
Milestone
0.20.0
Development

Successfully merging this pull request may close these issues.

DOC: docstrings of is_type_factory and is_instance_factory in config.py not accurate.
3 participants
@fumitoh @codecov-io @jreback