BUG: fix get_indexer_non_unique() with 'object' targets with NaNs (#4… #44483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johannes-mueller
force-pushed
the
bugfix/get-indexer-non-unique-object-nans-44482
branch
from
75ff6b0 to
f4d3b1a
Compare
johannes-mueller
force-pushed
the
bugfix/get-indexer-non-unique-object-nans-44482
branch
from
f4d3b1a to
1c73fba
Compare
…ndas-dev#44482) numpy.searchsorted() does not handle NaNs in 'object' arrays as expected (numpy/numpy#15499). Therefore we cannot search NaNs using binary search. So we use binary search only for targets without NaNs.
johannes-mueller
force-pushed
the
bugfix/get-indexer-non-unique-object-nans-44482
branch
from
1c73fba to
7e32f0c
Compare
|
Rebased & resolved conflict |
jreback
added
Bug
Indexing
|
thanks @johannes-mueller very nice, keep em coming! |
| @@ -332,3 +332,12 @@ def test_get_indexer_non_unique_multiple_nans(idx, target, expected): | |||
| axis = Index(idx) | |||
| actual = axis.get_indexer_for(target) | |||
| tm.assert_numpy_array_equal(actual, expected) | |||
|
|
|||
|
|
|||
| def test_get_indexer_non_unique_nans_in_object_dtype_target(nulls_fixture): | |||
There was a problem hiding this comment.
could also test NP_NAT_OBJECTS here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…4482)
numpy.searchsorted() does not handle NaNs in 'object' arrays as
expected (numpy/numpy#15499). Therefore we cannot search NaNs using binary
search. So we use binary search only for targets without NaNs.
This does also put the whatsnew of #44404 to the correct place.