BUG: testing on windows #15445
Closed
BUG: testing on windows #15445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jreback
commented
Feb 17, 2017
jreback
commented
- we are passing builds which actually have an error
- fix the small dtype issue
jreback
added
Testing
Codecov Report
@@ Coverage Diff @@
## master #15445 +/- ##
==========================================
- Coverage 90.37% 90.37% -0.01%
==========================================
Files 135 135
Lines 49464 49463 -1
==========================================
- Hits 44704 44703 -1
Misses 4760 4760
Continue to review full report at Codecov.
|
AnkurDedania
pushed a commit
to AnkurDedania/pandas
that referenced
this pull request
Mar 21, 2017
- we are passing builds which actually have an error - fix the small dtype issues Author: Jeff Reback <[email protected]> Closes pandas-dev#15445 from jreback/windows and squashes the following commits: a5b7fb3 [Jeff Reback] change integer to power comparisions eab15c4 [Jeff Reback] don't force remove pandas cf3b9bd [Jeff Reback] more windows fixing efe6a76 [Jeff Reback] add cython to build 8194e63 [Jeff Reback] don't use appveyor recipe, just build inplace e064825 [Jeff Reback] TST: resample dtype issue xref pandas-dev#15418 10d9b26 [Jeff Reback] TST: run windows tests so failures show up in appeveyor
jbrockmendel
reviewed
Apr 1, 2020
| @@ -13,8 +13,7 @@ def test_boolean_indexing(self): | |||
| [0, 1, 2, 10, 4, 5, 6, 7, 8, 9], | |||
| [10, 10, 10, 3, 4, 5, 6, 7, 8, 9]] | |||
| for cond, data in zip(conditions, expected_data): | |||
| result = df.copy() | |||
| result.loc[cond, 'x'] = 10 | |||
| result = df.assign(x=df.mask(cond, 10).astype('int64')) | |||
There was a problem hiding this comment.
@jreback do you remember what motivated this change? it makes it harder to tell what is being tested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.