Ensure the right values are set in SeriesGroupBy.nunique #15418
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We only need to use the group boundaries as the index for `res` so that the dimensions match those of `out`. Fixes pandas-dev#13453
|
can you add all 4 comparisions (e.g. so you have 4 cases that you are comparing for equality (you can call them result1-4 and compare) |
|
pls also add a bug fix note in 0.20.0. lgtm otherwise. ping on green! (with test additions) |
|
@aiguofer you shouldn't have any tests fail. Note we have recently switched to |
|
Added test to When I run tests with |
Codecov Report
@@ Coverage Diff @@
## master #15418 +/- ##
=======================================
Coverage 90.36% 90.36%
=======================================
Files 135 135
Lines 49438 49438
=======================================
Hits 44675 44675
Misses 4763 4763
Continue to review full report at Codecov.
|
|
@jreback all looks good :) |
|
thanks @aiguofer keep em coming! |
jreback
added a commit
to jreback/pandas
that referenced
this pull request
Feb 17, 2017
jreback
added a commit
to jreback/pandas
that referenced
this pull request
Feb 18, 2017
jreback
added a commit
that referenced
this pull request
Feb 18, 2017
- we are passing builds which actually have an error - fix the small dtype issues Author: Jeff Reback <[email protected]> Closes #15445 from jreback/windows and squashes the following commits: a5b7fb3 [Jeff Reback] change integer to power comparisions eab15c4 [Jeff Reback] don't force remove pandas cf3b9bd [Jeff Reback] more windows fixing efe6a76 [Jeff Reback] add cython to build 8194e63 [Jeff Reback] don't use appveyor recipe, just build inplace e064825 [Jeff Reback] TST: resample dtype issue xref #15418 10d9b26 [Jeff Reback] TST: run windows tests so failures show up in appeveyor
AnkurDedania
pushed a commit
to AnkurDedania/pandas
that referenced
this pull request
Mar 21, 2017
closes pandas-dev#13453 Author: Diego Fernandez <[email protected]> Closes pandas-dev#15418 from aiguofer/gh_13453 and squashes the following commits: c53bd70 [Diego Fernandez] Add test for pandas-dev#13453 in test_resample and add note to whatsnew 0daab80 [Diego Fernandez] Ensure the right values are set in SeriesGroupBy.nunique
AnkurDedania
pushed a commit
to AnkurDedania/pandas
that referenced
this pull request
Mar 21, 2017
- we are passing builds which actually have an error - fix the small dtype issues Author: Jeff Reback <[email protected]> Closes pandas-dev#15445 from jreback/windows and squashes the following commits: a5b7fb3 [Jeff Reback] change integer to power comparisions eab15c4 [Jeff Reback] don't force remove pandas cf3b9bd [Jeff Reback] more windows fixing efe6a76 [Jeff Reback] add cython to build 8194e63 [Jeff Reback] don't use appveyor recipe, just build inplace e064825 [Jeff Reback] TST: resample dtype issue xref pandas-dev#15418 10d9b26 [Jeff Reback] TST: run windows tests so failures show up in appeveyor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only need to use the group boundaries as the index for
resso thatthe dimensions match those of
out. Fixes #13453git diff upstream/master | flake8 --diff