-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
Mi indexing #15425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Mi indexing #15425
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
1f2f385
BUG: Fix indexing MultiIndex with Series with 0 not index
toobaz 0b719f5
Test for previous commit
toobaz 7606114
Whatsnew
toobaz 17209f3
BUG: support indexing MultiIndex with 1-D array
toobaz 8467b57
Tests for previous commit
toobaz 900e3ce
whatsnew
toobaz 2ba2d5d
Updated comment
toobaz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1521,15 +1521,24 @@ def _getitem_axis(self, key, axis=0): | |
return self._getbool_axis(key, axis=axis) | ||
elif is_list_like_indexer(key): | ||
|
||
# GH 7349 | ||
# possibly convert a list-like into a nested tuple | ||
# but don't convert a list-like of tuples | ||
# convert various datatypes to a list of keys | ||
if isinstance(labels, MultiIndex): | ||
if isinstance(key, ABCSeries): | ||
# GH 14730 | ||
key = key.values.tolist() | ||
elif isinstance(key, ABCDataFrame): | ||
# GH 15438 | ||
raise NotImplementedError("Indexing a MultiIndex with a " | ||
"DataFrame key is not " | ||
"implemented") | ||
elif hasattr(key, 'ndim') and key.ndim > 1: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. test using a numpy scalar as well (which is 0-dim), e.g. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. done |
||
raise NotImplementedError("Indexing a MultiIndex with a " | ||
"multidimensional key is not " | ||
"implemented") | ||
elif isinstance(key, np.ndarray): | ||
key = key.tolist() | ||
if (not isinstance(key, tuple) and len(key) > 1 and | ||
not isinstance(key[0], tuple)): | ||
if isinstance(key, ABCSeries): | ||
# GH 14730 | ||
key = list(key) | ||
key = tuple([key]) | ||
|
||
# an iterable multi-selection | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Related to (the code I currently don't understand in) #15448