BUG: Trivial fix to #15447 #15448
Closed
BUG: Trivial fix to #15447 #15448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@toobaz you know that you can simply do this on your own fork. Please only do a pull request when you actually want to merge something (with tests and such). |
|
@jreback as I wrote, I have no problem in adding a test, that's not the point. The point is whether you want to apply the fix, given that I don't understand that code. |
|
well with a suite of tests sure this type of indexing for sparse is barely tested in fact what would be great would be a bunch of tests - see what works, and what doesn't u can xfail (and then when it's fixed it will be good) we need systematic testing for this |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master | flake8 --diffThis is not really meant for merging because I don't understand that piece code and don't have time to understand it. But if you want to merge it anyway I can add a test and a whatsnew entry.