BUG/API: Return a Series from DataFrame.asof with no match #15232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
reviewed
Jan 26, 2017
| @@ -67,6 +68,22 @@ def test_subset(self): | |||
|
|
|||
| assert_frame_equal(result, expected) | |||
|
|
|||
| def test_missing(self): | |||
| # GH 15118 | |||
There was a problem hiding this comment.
can you add a 1-liner describing this test (what its doing)
jreback
reviewed
Jan 26, 2017
| @@ -327,7 +327,7 @@ Other API Changes | |||
| - ``pd.read_csv()`` will now raise a ``ValueError`` for the C engine if the quote character is larger than than one byte (:issue:`11592`) | |||
| - ``inplace`` arguments now require a boolean value, else a ``ValueError`` is thrown (:issue:`14189`) | |||
| - ``pandas.api.types.is_datetime64_ns_dtype`` will now report ``True`` on a tz-aware dtype, similar to ``pandas.api.types.is_datetime64_any_dtype`` | |||
|
|
|||
| - ``DataFrame.asof`` will return a null filled ``Series`` instead the scalar ``NaN`` if a match is not found (:issue:`15118`) | |||
|
minor comments, lgtm. ok on the API change (usually these are more 'visible' even if its a 'bug fix') |
|
merge on green. |
Current coverage is 86.31% (diff: 100%)@@ master #15232 diff @@
==========================================
Files 139 139
Lines 51091 51094 +3
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 44099 44102 +3
Misses 6992 6992
Partials 0 0
|
AnkurDedania
pushed a commit
to AnkurDedania/pandas
that referenced
this pull request
Mar 21, 2017
…v#15232) * BUG/API: Return a Series from DataFrame.asof no match * doc fixups
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master | flake8 --diffTechnically this is an API change, but more of a bug so didn't think there was a need to warn / deprecate?
Also there seems to be room to clean up the whole
asofimplementation, xref #10343, but wanted to keep that separate