Skip to content

CLN: Series.asof #10343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bwillers opened this issue Jun 13, 2015 · 1 comment
Closed

CLN: Series.asof #10343

bwillers opened this issue Jun 13, 2015 · 1 comment
Labels
Clean Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate

Comments

@bwillers
Copy link
Contributor

As discussed in #10266 Series.asof is effectively equivalent to s.dropna().reindex(where, method='ffill'). The implementation of Series.asof uses Index.asof_locs, which is used no where else in the code, and is untested. So deprecating Series.asof might make sense.

Let's add the impls discussed (IOW, implement .asof in terms of reindexing internally). Further let's add tests for .asof_locs (though this maybe abel to tbe removed)

@jreback jreback added Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate Deprecate Functionality to remove in pandas labels Jun 14, 2015
@jreback jreback added this to the 0.17.0 milestone Jun 14, 2015
@jreback jreback changed the title DEPR: deprecating Series.asof CLN: Series.asof Aug 13, 2015
@jreback jreback modified the milestones: Next Major Release, 0.17.0 Aug 13, 2015
@jreback jreback added Clean and removed Deprecate Functionality to remove in pandas labels Aug 21, 2015
@jreback jreback modified the milestones: 0.17.0, Next Major Release Aug 21, 2015
@jreback jreback modified the milestones: Next Major Release, 0.17.0 Sep 1, 2015
@jbrockmendel
Copy link
Member

We have decent tests for Index.asof and DatetimeIndex.asof. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate
Projects
None yet
3 participants