-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
BF: boost min cython to 0.23 #14831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BF: boost min cython to 0.23 #14831
Conversation
prob need to change a few travis setups in ci |
what is btw really the lowest version of cython which works in your setups and passes the tests? 0.23 here is somewhat arbitrary one higher than 0.21.1 where 14699 manifested |
Current coverage is 85.26% (diff: 100%)@@ master #14831 diff @@
==========================================
Files 144 144
Lines 50980 50980
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 43469 43469
Misses 7511 7511
Partials 0 0
|
|
@yarikoptic I think 0.23 is fine. if you can add a note on 0.20.0 whatsnew. also need to update |
interesting -- now 2nd env in travis fails due to failing to find pandas/index.c any immediate clue why? |
@yarikoptic that build is still installing cython 0.19.1 (see the requirements-2.7_LOCALE.build file), so it acts like cython is not installed (I only thought we had a better error message for such cases) |
69b4095
to
7ce8036
Compare
LGTM |
seem some files have no changes? can you add a note in the whatsnew 0.20.0 (in addition to the one you have), about the development requireing a higher version. can you see if anything needs to be changed in contributing.rst otherwise lgtm. |
* origin/master: (22 commits) BUG: astype falsely converts inf to integer (GH14265) (pandas-dev#14343) BUG: Apply min_itemsize to index even when not appending DOC: warning section on memory overflow when joining/merging dataframes on index with duplicate keys (pandas-dev#14788) BLD: missing - on secure BLD: new access token on pandas-dev TST: Test DatetimeIndex weekend offset (pandas-dev#14853) BLD: escape GH_TOKEN in build_docs TST: Correct results with np.size and crosstab (pandas-dev#4003) (pandas-dev#14755) Frame benchmarking sum instead of mean (pandas-dev#14824) CLN: lint of test_base.py BUG: Allow TZ-aware DatetimeIndex in merge_asof() (pandas-dev#14844) BUG: GH11847 Unstack with mixed dtypes coerces everything to object TST: skip testing on windows for specific formatting which sometimes hangs (pandas-dev#14851) BLD: try new gh token for pandas-docs CLN/PERF: clean-up of the benchmarks (pandas-dev#14099) ENH: add timedelta as valid type for interpolate with method='time' (pandas-dev#14799) DOC: add section on groupby().rolling/expanding/resample (pandas-dev#14801) TST: add test to confirm GH14606 (specify category dtype for empty) (pandas-dev#14752) BLD: use org name in build-docs.sh BF(TST): use = (native) instead of < (little endian) for target data types (pandas-dev#14832) ...
|
thank you sir! |
closes pandas-dev#14699 closes pandas-dev#14831 closes pandas-dev#14508
closes #14699
closes #14508