TST: Test DatetimeIndex weekend offset #14853
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
reviewed
Dec 10, 2016
| result = idx1.append(idx2) | ||
| expected = DatetimeIndex([d1, d2, d3]) | ||
| tm.assert_index_equal(result, expected) | ||
| # GH 5115 |
jreback
reviewed
Dec 10, 2016
| d3 = date(2012, 9, 30) | ||
| idx1 = DatetimeIndex([d1, d2]) | ||
| idx2 = DatetimeIndex([d3]) | ||
| result = idx1.append(idx2) |
There was a problem hiding this comment.
the original operation was a .union (but testing append is ok too), so add a test for .union
jreback
added
Frequency
Test union & formatting
mroeschke
force-pushed
the
test_datetimeindex_frequencies
branch
from
1153c86 to
736ebb2
Compare
Current coverage is 85.26% (diff: 100%)@@ master #14853 diff @@
==========================================
Files 144 144
Lines 50981 50981
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 43469 43470 +1
+ Misses 7512 7511 -1
Partials 0 0
|
|
@mroeschke Thanks a lot, this is really useful for cleaning up the issues! |
yarikoptic
added a commit
to neurodebian/pandas
that referenced
this pull request
Dec 12, 2016
* origin/master: (22 commits) BUG: astype falsely converts inf to integer (GH14265) (pandas-dev#14343) BUG: Apply min_itemsize to index even when not appending DOC: warning section on memory overflow when joining/merging dataframes on index with duplicate keys (pandas-dev#14788) BLD: missing - on secure BLD: new access token on pandas-dev TST: Test DatetimeIndex weekend offset (pandas-dev#14853) BLD: escape GH_TOKEN in build_docs TST: Correct results with np.size and crosstab (pandas-dev#4003) (pandas-dev#14755) Frame benchmarking sum instead of mean (pandas-dev#14824) CLN: lint of test_base.py BUG: Allow TZ-aware DatetimeIndex in merge_asof() (pandas-dev#14844) BUG: GH11847 Unstack with mixed dtypes coerces everything to object TST: skip testing on windows for specific formatting which sometimes hangs (pandas-dev#14851) BLD: try new gh token for pandas-docs CLN/PERF: clean-up of the benchmarks (pandas-dev#14099) ENH: add timedelta as valid type for interpolate with method='time' (pandas-dev#14799) DOC: add section on groupby().rolling/expanding/resample (pandas-dev#14801) TST: add test to confirm GH14606 (specify category dtype for empty) (pandas-dev#14752) BLD: use org name in build-docs.sh BF(TST): use = (native) instead of < (little endian) for target data types (pandas-dev#14832) ...
ischurov
pushed a commit
to ischurov/pandas
that referenced
this pull request
Dec 19, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #5348
closes #5115
closes #5152
The original issues pass on master as of 0.19.1. These related issues might have been fixed part of #5004, but it doesn't look like that any PRs fixed this recently.