Skip to content

DOC: fix incorrect example in unstack docstring (GH14206) #14211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 13, 2016
Merged

Conversation

sudk1896
Copy link

@sudk1896 sudk1896 commented Sep 13, 2016

The following PR closes #14206 and corrects the Docs as suggested in the issue thread.
@jorisvandenbossche Kindly review.

@jorisvandenbossche
Copy link
Member

I don't think you actually changed the output? (apart from the floating notation, which is OK). It is the output of df.unstack() that was wrong (the 2 and 3 are swapped), and which should be corrected.

@codecov-io
Copy link

codecov-io commented Sep 13, 2016

Current coverage is 85.24% (diff: 100%)

Merging #14211 into master will decrease coverage by <.01%

@@             master     #14211   diff @@
==========================================
  Files           140        140          
  Lines         50563      50566     +3   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits          43103      43103          
- Misses         7460       7463     +3   
  Partials          0          0          

Powered by Codecov. Last update 461e0e9...99c2f0b

@sudk1896
Copy link
Author

@jorisvandenbossche : Oops, my bad. I corrected the mistake now.

@jreback jreback added this to the 0.19.0 milestone Sep 13, 2016
@jorisvandenbossche jorisvandenbossche changed the title Doc fix for DataFrame.unstack() DOC: fix incorrect example in unstack docstring (GH14206) Sep 13, 2016
@jorisvandenbossche jorisvandenbossche merged commit 5e665b3 into pandas-dev:master Sep 13, 2016
@jorisvandenbossche
Copy link
Member

@sudk1896 Thanks for the fix!
(small note: you had a small trailing whitespace error which was captured by our linter (I corrected it), but I would recommend setting your editor to automatically remove trailing whitespace)

@sudk1896
Copy link
Author

@jorisvandenbossche: Will do from next time. Thanks.

yarikoptic added a commit to neurodebian/pandas that referenced this pull request Oct 13, 2016
* commit 'v0.19.0rc1-25-ga7469cf': (471 commits)
  ENH: Add divmod to series and index. (pandas-dev#14208)
  Fix generator tests to run (pandas-dev#14245)
  BUG: GH13629 Binned groupby median function with empty bins (pandas-dev#14225)
  TST/TEMP: fix pyqt to 4.x for plotting tests (pandas-dev#14240)
  DOC: added example to Series.map showing use of na_action parameter (GH14231)
  DOC: split docstring into multiple lines in excel.py (pandas-dev#14073)
  MAINT: Use __module__ in _DeprecatedModule. (pandas-dev#14181)
  ENH: Allow true_values and false_values options in read_excel (pandas-dev#14002)
  DOC: fix incorrect example in unstack docstring (GH14206) (pandas-dev#14211)
  BUG: iloc fails with non lex-sorted MultiIndex pandas-dev#13797
  BUG: add check for infinity in __call__ of EngFormatter
  In gbq.to_gbq allow the DataFrame column order to differ from schema
  BLD: require cython if tempita is needed
  DOC: add source links to api docs (pandas-dev#14200)
  BUG: compat with Stata ver 111
  Fix: F999 dictionary key '2000q4' repeated with different values (pandas-dev#14198)
  BLD: Test for Python 3.5 with C locale
  BUG: DatetimeTZBlock can't assign values near dst boundary
  BUG: union_categorical with Series and cat idx
  BUG: fix str.contains for series containing only nan values
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pandas.DataFrame.unstack() documentation example has errors
4 participants