Skip to content

MAINT: Use __module__ in _DeprecatedModule. #14181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

gfyoung
Copy link
Member

@gfyoung gfyoung commented Sep 8, 2016

Follow-up to #14105. Uses the __module__ method to correctly determine the location of the alternative
module to use.

@codecov-io
Copy link

codecov-io commented Sep 8, 2016

Current coverage is 85.25% (diff: 86.66%)

Merging #14181 into master will increase coverage by 0.01%

@@             master     #14181   diff @@
==========================================
  Files           140        140          
  Lines         50555      50544    -11   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits          43095      43091     -4   
+ Misses         7460       7453     -7   
  Partials          0          0          

Powered by Codecov. Last update 8af6264...2e581ab

@gfyoung gfyoung force-pushed the datetools-depr-cont branch from dc59364 to 8221c59 Compare September 8, 2016 04:40
@jreback jreback added the Clean label Sep 8, 2016
@jreback
Copy link
Contributor

jreback commented Sep 8, 2016

somethings wrong. so now dir(pandas.datetools) works, but

from pandas.core.datetools import yearEnd does not show a warning

nor does tab completion on the module

In [1]: from pandas.core.datetools import /Users/jreback/miniconda/lib/python2.7/site-packages/IPython/core/completerlib.py:158: FutureWarning: The pandas.core.datetools module is deprecated and will be removed in a future ver.
  m = __import__(mod)               

                         ABCDataFrame             BDay                     BMonthEnd                businessDay              cache_readonly           CDay                     CustomBusinessHour       DateParseError            
                         ABCIndexClass            bday                     BQuarterBegin            BusinessHour             CBMonthBegin             cday                     customBusinessMonthBegin datetime                  
                         ABCSeries                bmonthBegin              BQuarterEnd              BYearBegin               cbmonthBegin             compat                   customBusinessMonthEnd   Day                      >
                         algos                    BMonthBegin              bquarterEnd              BYearEnd                 CBMonthEnd               customBusinessDay        D_RESO                   day                       

can you add some tests for this

@gfyoung
Copy link
Member Author

gfyoung commented Sep 8, 2016

@jreback : Did tab completion work before?

@jreback
Copy link
Contributor

jreback commented Sep 8, 2016

yes

Follow-up to pandas-devgh-14105. Uses the '__module__' method
to correctly determine the location of the alternative
module to use.
@gfyoung gfyoung force-pushed the datetools-depr-cont branch from 8221c59 to 2e581ab Compare September 9, 2016 03:58
@gfyoung
Copy link
Member Author

gfyoung commented Sep 9, 2016

@jreback : I couldn't get tab completion to issue a warning like that on master. Still not sure why the pandas.core.datetools import stopped issuing warnings. I think it is because I imported the module once during __init__ with a filter.

@jreback
Copy link
Contributor

jreback commented Sep 9, 2016

wel it needs to be the same as master and have the warning and have the same behavior as 0.18.1 for function

@gfyoung
Copy link
Member Author

gfyoung commented Sep 9, 2016

@jreback : Fair enough. I made some modifications. Can you take a look?

@jreback
Copy link
Contributor

jreback commented Sep 9, 2016

tab complete / warnings loooking good

In [1]: import pandas

In [2]: from pandas.core.datetools import C:\Anaconda\envs\pandas3.5\lib\site-packages\IPython\core\completerlib.py:158: FutureWarning: The pandas.core.datetools module is deprecated and will be removed in a future version. Please use the pandas.tseries module instead.
  m = __import__(mod)

In [3]: from pandas.core.datetools import yearEnd
In [1]: pd.datetools.yearEnd
C:\Anaconda\envs\pandas3.5\Scripts\ipython-script.py:1: FutureWarning: pandas.core.datetools.yearEnd is deprecated and will be removed in a future version.
  if __name__ == '__main__':
Out[1]: <YearEnd: month=12>

@jreback jreback added this to the 0.19.0 milestone Sep 9, 2016
@jreback
Copy link
Contributor

jreback commented Sep 9, 2016

lgtm. @jorisvandenbossche

@jorisvandenbossche jorisvandenbossche merged commit 9554195 into pandas-dev:master Sep 14, 2016
@jorisvandenbossche
Copy link
Member

@gfyoung Thanks a lot!

@gfyoung gfyoung deleted the datetools-depr-cont branch September 14, 2016 14:52
yarikoptic added a commit to neurodebian/pandas that referenced this pull request Oct 13, 2016
* commit 'v0.19.0rc1-25-ga7469cf': (471 commits)
  ENH: Add divmod to series and index. (pandas-dev#14208)
  Fix generator tests to run (pandas-dev#14245)
  BUG: GH13629 Binned groupby median function with empty bins (pandas-dev#14225)
  TST/TEMP: fix pyqt to 4.x for plotting tests (pandas-dev#14240)
  DOC: added example to Series.map showing use of na_action parameter (GH14231)
  DOC: split docstring into multiple lines in excel.py (pandas-dev#14073)
  MAINT: Use __module__ in _DeprecatedModule. (pandas-dev#14181)
  ENH: Allow true_values and false_values options in read_excel (pandas-dev#14002)
  DOC: fix incorrect example in unstack docstring (GH14206) (pandas-dev#14211)
  BUG: iloc fails with non lex-sorted MultiIndex pandas-dev#13797
  BUG: add check for infinity in __call__ of EngFormatter
  In gbq.to_gbq allow the DataFrame column order to differ from schema
  BLD: require cython if tempita is needed
  DOC: add source links to api docs (pandas-dev#14200)
  BUG: compat with Stata ver 111
  Fix: F999 dictionary key '2000q4' repeated with different values (pandas-dev#14198)
  BLD: Test for Python 3.5 with C locale
  BUG: DatetimeTZBlock can't assign values near dst boundary
  BUG: union_categorical with Series and cat idx
  BUG: fix str.contains for series containing only nan values
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants