-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
MAINT: Use __module__ in _DeprecatedModule. #14181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: Use __module__ in _DeprecatedModule. #14181
Conversation
Current coverage is 85.25% (diff: 86.66%)@@ master #14181 diff @@
==========================================
Files 140 140
Lines 50555 50544 -11
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 43095 43091 -4
+ Misses 7460 7453 -7
Partials 0 0
|
dc59364
to
8221c59
Compare
somethings wrong. so now
nor does tab completion on the module
can you add some tests for this |
@jreback : Did tab completion work before? |
yes |
Follow-up to pandas-devgh-14105. Uses the '__module__' method to correctly determine the location of the alternative module to use.
8221c59
to
2e581ab
Compare
@jreback : I couldn't get tab completion to issue a warning like that on |
wel it needs to be the same as master and have the warning and have the same behavior as 0.18.1 for function |
@jreback : Fair enough. I made some modifications. Can you take a look? |
tab complete / warnings loooking good
|
lgtm. @jorisvandenbossche |
@gfyoung Thanks a lot! |
* commit 'v0.19.0rc1-25-ga7469cf': (471 commits) ENH: Add divmod to series and index. (pandas-dev#14208) Fix generator tests to run (pandas-dev#14245) BUG: GH13629 Binned groupby median function with empty bins (pandas-dev#14225) TST/TEMP: fix pyqt to 4.x for plotting tests (pandas-dev#14240) DOC: added example to Series.map showing use of na_action parameter (GH14231) DOC: split docstring into multiple lines in excel.py (pandas-dev#14073) MAINT: Use __module__ in _DeprecatedModule. (pandas-dev#14181) ENH: Allow true_values and false_values options in read_excel (pandas-dev#14002) DOC: fix incorrect example in unstack docstring (GH14206) (pandas-dev#14211) BUG: iloc fails with non lex-sorted MultiIndex pandas-dev#13797 BUG: add check for infinity in __call__ of EngFormatter In gbq.to_gbq allow the DataFrame column order to differ from schema BLD: require cython if tempita is needed DOC: add source links to api docs (pandas-dev#14200) BUG: compat with Stata ver 111 Fix: F999 dictionary key '2000q4' repeated with different values (pandas-dev#14198) BLD: Test for Python 3.5 with C locale BUG: DatetimeTZBlock can't assign values near dst boundary BUG: union_categorical with Series and cat idx BUG: fix str.contains for series containing only nan values ...
Follow-up to #14105. Uses the
__module__
method to correctly determine the location of the alternativemodule to use.