DEPR: Deprecate Timestamp.to_datetime #14101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfyoung
force-pushed
the
ts-to-datetime-depr
branch
from
c449999 to
386c6a0
Compare
| cdef: | ||
| pandas_datetimestruct dts | ||
| _TSObject ts | ||
|
|
||
| if self.nanosecond != 0 and warn: | ||
| print 'Warning: discarding nonzero nanoseconds' |
There was a problem hiding this comment.
maybe we should make this an actual warning
Current coverage is 85.26% (diff: 100%)@@ master #14101 diff @@
==========================================
Files 139 139
Lines 50502 50502
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 43063 43062 -1
- Misses 7439 7440 +1
Partials 0 0
|
|
|
||
| if self.nanosecond != 0 and warn: | ||
| warnings.warn("Discarding nonzero nanoseconds in conversion", | ||
| UserWarning, stacklevel=2) |
There was a problem hiding this comment.
hmm maybe RuntimeWarning is better? not sure when that is typically used
There was a problem hiding this comment.
I think user warning makes more sense here because this is converting user-provided data.
gfyoung
force-pushed
the
ts-to-datetime-depr
branch
from
2a73742 to
0de77be
Compare
gfyoung
force-pushed
the
ts-to-datetime-depr
branch
from
0de77be to
1fe9f46
Compare
|
@jorisvandenbossche , @jreback : Travis is giving the green light, so this should be ready to merge if there are no other concerns. |
|
@gfyoung Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NaT.to_datetimeTimestamp.to_datetimeUserWarninginTimestamp.to_datetimewhen nanoseconds is non-zeroNaTis also a_Timestamp, so the second deprecation covered the first one as well.Closes #8254.