Skip to content

Commit 1fe9f46

Browse files
committed
DEPR: Deprecate NaT.to_datetime
Closes gh-8254.
1 parent 88eefc1 commit 1fe9f46

File tree

2 files changed

+9
-3
lines changed

2 files changed

+9
-3
lines changed

pandas/tseries/tests/test_timeseries.py

+7-1
Original file line numberDiff line numberDiff line change
@@ -1020,7 +1020,13 @@ def test_NaT_methods(self):
10201020

10211021
for method in nat_methods:
10221022
if hasattr(NaT, method):
1023-
self.assertIs(getattr(NaT, method)(), NaT)
1023+
# see gh-8254
1024+
exp_warning = None
1025+
if method == 'to_datetime':
1026+
exp_warning = FutureWarning
1027+
with tm.assert_produces_warning(
1028+
exp_warning, check_stacklevel=False):
1029+
self.assertIs(getattr(NaT, method)(), NaT)
10241030

10251031
# GH 12300
10261032
self.assertEqual(NaT.isoformat(), 'NaT')

pandas/tslib.pyx

+2-2
Original file line numberDiff line numberDiff line change
@@ -791,11 +791,11 @@ def _make_nan_func(func_name):
791791
f.__name__ = func_name
792792
return f
793793

794-
_nat_methods = ['date', 'now', 'replace', 'to_datetime', 'today']
794+
_nat_methods = ['date', 'now', 'replace', 'to_pydatetime', 'today']
795795

796796
_nan_methods = ['weekday', 'isoweekday', 'total_seconds']
797797

798-
_implemented_methods = ['to_datetime64', 'isoformat']
798+
_implemented_methods = ['to_datetime', 'to_datetime64', 'isoformat']
799799
_implemented_methods.extend(_nat_methods)
800800
_implemented_methods.extend(_nan_methods)
801801

0 commit comments

Comments
 (0)