Skip to content

DOC: add data_columns to doc string of to_hdf and HDFStore.append #14046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jorisvandenbossche
Copy link
Member

Follow-up of #13951, rebase of PR #13065

@jorisvandenbossche
Copy link
Member Author

I combined the changes of #13065 with the changes merged in #13951 (found the explanation a bit clearer in #13065), and fixed the formatting

@jorisvandenbossche jorisvandenbossche added this to the 0.19.0 milestone Aug 19, 2016
@codecov-io
Copy link

Current coverage is 85.25% (diff: 100%)

Merging #14046 into master will not change coverage

@@             master     #14046   diff @@
==========================================
  Files           139        139          
  Lines         50380      50380          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits          42953      42953          
  Misses         7427       7427          
  Partials          0          0          

Powered by Codecov. Last update 453bc26...142fb78

@jorisvandenbossche
Copy link
Member Author

jorisvandenbossche commented Aug 19, 2016

@jreback the way to prevent the need for #noqa in docstrings for long lines (as that is rather strange in the html docs), is to ensure that the too long line consists of only one word/url (so no spaces), then the linter does not complaining.

So in this example, I changed

...
`here <http://pandas.pydata.org/pandas-docs/stable/io.html#query-via-data-columns>`__ # noqa
...

with

... `here 
<http://pandas.pydata.org/pandas-docs/stable/io.html#query-via-data-columns>`__
...

(just letting you know for reviewing purposes :-)) Maybe we should document that somewhere ..

@jorisvandenbossche jorisvandenbossche merged commit 49af018 into pandas-dev:master Aug 19, 2016
@jreback
Copy link
Contributor

jreback commented Aug 19, 2016

@jorisvandenbossche ahh good to know

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants