DOC: NDFrame.to_hdf(data_columns) documented (#13061). #13951
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1126,7 +1124,9 @@ def to_hdf(self, path_or_buf, key, **kwargs): | |||
| If applying compression use the fletcher32 checksum | |||
| dropna : boolean, default False. | |||
| If true, ALL nan rows will not be written to store. | |||
|
|
|||
| data_columns : list of columns to create as data columns, or True to | |||
| use all columns. If True and format='table', data will be written | |||
There was a problem hiding this comment.
this last line is superfluous. This and HDFStore.append for data_columns should be the same. pls add a link to the docs in both.
There was a problem hiding this comment.
@jreback Can you clarify what you mean by "add a link to the docs in both"?
There was a problem hiding this comment.
a ref to: http://pandas.pydata.org/pandas-docs/stable/io.html#query-via-data-columns
and ideally adding references as needed (e.g. compression) and for the format option
Current coverage is 85.25% (diff: 100%)@@ master #13951 diff @@
==========================================
Files 139 139
Lines 50381 50381
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 42953 42953
Misses 7428 7428
Partials 0 0
|
|
@jreback Can you review this again? I've updated it as per your previous comments. |
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master | flake8 --diffI'm aware there's another PR for the same issue, but it hasn't had activity in a while so this is my attempt. I took the opportunity to remove the unusable "mode=r" option from the same docstring, and make the title clearer.