Skip to content

TST/ERR: Add Period ops tests / fix error message #13250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

TST/ERR: Add Period ops tests / fix error message #13250

wants to merge 1 commit into from

Conversation

sinhrks
Copy link
Member

@sinhrks sinhrks commented May 21, 2016 •
edited by jreback
Loading

closes #13251

  • tests added / passed
  • passes git diff upstream/master | flake8 --diff

This must be after #13079.

@sinhrks sinhrks added Testing pandas testing functions or related to the test suite Period Period data type labels May 21, 2016
@sinhrks sinhrks added this to the 0.18.2 milestone May 21, 2016
@jreback jreback mentioned this pull request May 21, 2016
Closed
@jreback
Copy link
Contributor

jreback commented May 21, 2016

merged #13079
see my comments on #13251 (may already be covered here)

@sinhrks sinhrks changed the title (WIP) TST/ERR: Add Period ops tests / fix error message TST/ERR: Add Period ops tests / fix error message May 21, 2016
@jreback jreback closed this in b88eb35 May 22, 2016
@jreback
Copy link
Contributor

jreback commented May 22, 2016

thanks @sinhrks all of these tests are really helpful!

@jreback jreback mentioned this pull request May 22, 2016
Closed
5 tasks
@sinhrks sinhrks deleted the period_test branch May 22, 2016 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Period Period data type Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
0.19.0
Development

Successfully merging this pull request may close these issues.

TST: assert that IncompatibleFrequency is raise (rather than ValueError)
2 participants
@sinhrks @jreback