Skip to content

TST: assert that IncompatibleFrequency is raise (rather than ValueError) #13251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jreback opened this issue May 21, 2016 · 3 comments
Closed

TST: assert that IncompatibleFrequency is raise (rather than ValueError) #13251

jreback opened this issue May 21, 2016 · 3 comments
Labels
Period Period data type Testing pandas testing functions or related to the test suite
Milestone
0.19.0

Comments

@jreback
Copy link
Contributor

jreback commented May 21, 2016

#13079 (comment)

just need to make sure that we are raising IncompatibleFrequency as appropriate (and testing explicity for this rather than ValueError) when constructing Periods.
@jreback jreback added Testing pandas testing functions or related to the test suite Period Period data type labels May 21, 2016
@jreback jreback added this to the 0.18.2 milestone May 21, 2016
@jreback
Copy link
Contributor Author

jreback commented May 21, 2016

#13250 prob convers most/all of this.

@jreback jreback mentioned this issue May 21, 2016
Closed
3 tasks
@sinhrks
Copy link
Member

sinhrks commented May 21, 2016

Yes, covered in #13250.

@jreback
Copy link
Contributor Author

jreback commented May 21, 2016

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Period Period data type Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
0.19.0
Development

Successfully merging a pull request may close this issue.

TST/ERR: Add Period ops tests / fix error message sinhrks/pandas
2 participants
@jreback @sinhrks