Skip to content

Improve error message for category dtype in HDF5, format="fixed" store. #13093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Improve error message for category dtype in HDF5, format="fixed" store. #13093

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8f436dc
Improve error message for category dtype in HDF5, format="fixed" store.
chrish42 May 5, 2016
9a6ef08
Wrap line to be less than 80 characters.
chrish42 May 5, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pandas/io/pytables.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2517,7 +2517,7 @@ def write_array(self, key, value, items=None):
transposed = False

if com.is_categorical_dtype(value):
raise NotImplementedError("cannot store a category dtype")
raise NotImplementedError('Cannot store a category dtype in a HDF5 dataset that uses format="fixed". Use format="table".')
Copy link
Contributor

@jreback jreback May 5, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine but this will fail PEP, break the line:

raise NotImplementedError(" ......... "
                          " ......... "
                          " ..........")

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. (Although it would have been easier if the Github text editor showed the column number.)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah I think it just shows a screen width of 80. This would have failed our tests as they lint.


if not empty_array:
value = value.T
Expand Down