Improve error message for category dtype in HDF5, format="fixed" store. #13093
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A more explicit (and helpful) error message would have helped me discover sooner that format="table" supported categorical data.
| @@ -2517,7 +2517,7 @@ def write_array(self, key, value, items=None): | |||
| transposed = False | |||
|
|
|||
| if com.is_categorical_dtype(value): | |||
| raise NotImplementedError("cannot store a category dtype") | |||
| raise NotImplementedError('Cannot store a category dtype in a HDF5 dataset that uses format="fixed". Use format="table".') | |||
There was a problem hiding this comment.
fine but this will fail PEP, break the line:
raise NotImplementedError(" ......... "
" ......... "
" ..........")
There was a problem hiding this comment.
Done. (Although it would have been easier if the Github text editor showed the column number.)
There was a problem hiding this comment.
yeah I think it just shows a screen width of 80. This would have failed our tests as they lint.
|
lgtm. If you find others, pls submit! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A more explicit (and helpful) error message would have helped me discover sooner that format="table" supported categorical data.