Fix #12695 : RangeIndex generated with pd.concat with ignore_index as True #12696
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1079,8 +1079,7 @@ def _get_concat_axis(self): | |||
| if self.axis == 0: | |||
| indexes = [x.index for x in self.objs] | |||
| elif self.ignore_index: | |||
| idx = Index(np.arange(len(self.objs))) | |||
| idx.is_unique = True # arange is always unique | |||
| idx = RangeIndex(len(self.objs)) | |||
There was a problem hiding this comment.
use com._default_index(...) (you can create above and use in the comparison as well)
|
tests! always start with the tests to make sure it fails first! |
|
4 tasks
|
Thanks for the PR:) But I've included the fix in #12846 to refactor existing code. Pls lmk if anything. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master | flake8 --diffReplaced generated indexes with RangeIndex, test still needed