BUG: GH12290 where tz_convert used values of uninitialized arrays #12306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kawochen
force-pushed
the
BUG-FIX-12290
branch
from
8d904c9 to
db9807b
Compare
|
aha! |
| @@ -3530,7 +3530,7 @@ def tz_convert(ndarray[int64_t] vals, object tz1, object tz2): | |||
| if _get_zone(tz2) == 'UTC': | |||
| return utc_dates | |||
|
|
|||
| result = np.empty(n, dtype=np.int64) | |||
| result = np.zeros(n, dtype=np.int64) | |||
| if _is_tzlocal(tz2): | |||
There was a problem hiding this comment.
Is this supposed to be a fast path? If tz2 is a string it doesn't take this path.
There was a problem hiding this comment.
i don't think it's supposed to actually be a string
as _maybe_get_tz is called I think
but u can compare it to UTC
There was a problem hiding this comment.
@kawochen : Hmmm...that would certainly explain why I was having a hard time reproducing it. np.empty produces unpredictable values for np.int64 and could easily produce the NPY_NAT value. If all your tests pass, I'll close my PR.
kawochen
force-pushed
the
BUG-FIX-12290
branch
from
db9807b to
38bed4d
Compare
|
the closes directive for the actual PR Is created at merge time |
|
updated according to @gfyoung's comment |
jreback
added a commit
that referenced
this pull request
Feb 13, 2016
closes #12217 xref #12306 which I think fixed Author: Jeff Reback <[email protected]> Closes #12316 from jreback/concat and squashes the following commits: 563b23b [Jeff Reback] TST: validation tests for concat of same timezones
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #12290