BUG: Fix subtraction with timezone Series #12302
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fixed by #12306 |
|
ah sorry didn't realize there was already a PR. thought I was quick! |
|
ahh, but I think @kawochen soln fixes the root of the problem. |
Fixes unusual bug with timezone Series subtraction in which single element Series objects containing tz-aware objects would return a timedelta of zero, even though it visually could not be the case. The bug was traced to the conversion of the contained timezones to UTC, in which the method call was somehow returning NaT, even though attempts to replicate that behaviour were unsuccessful. This new method call fixes the issue and is in some ways more intuitive given the comment above the conversions. Closes pandas-devgh-12290.
gfyoung
force-pushed
the
tz_series_diff_patch
branch
from
4b1a39b to
29581d1
Compare
|
Closing this PR because #12306 provides a better solution to the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue in #12290 with timezone
Seriessubtraction in which single elementSeriesobjects containing tz-aware objects would return a timedelta of zero, even though it visually could not be the case.
The bug was traced to the conversion of the contained timezones to UTC, in which the method call was somehow returning
NaT, even though attempts to replicate that behaviour were unsuccessful. This newmethod call fixes the issue and is in some ways more intuitive given the comment above the conversions.