CLN: fix all flake8 warnings in pandas/tools #12082
Conversation
| Keys to group by on the pivot table column. | ||
| If an array is passed, it is being used as the same manner as column values. | ||
| index : a column, Grouper, array which has the same length as data, or list | ||
| of them. |
There was a problem hiding this comment.
this is another numpydoc problem ...
the type specification should be on one line to have to formatted well in the html docs (as the first line after the colon is formatted in italic), and then second line is the start of the explanation
There was a problem hiding this comment.
In this case, maybe just shorten it a bit? (maybe 'array which has the same length' -> 'array of same length' is enough to keep within line limit?)
But if this happens more, we should maybe look if we can solve this in the numpydoc parser
There was a problem hiding this comment.
Yeah, the original versions contained commingled types and descriptions. Let me do a proper job fixing
|
For the rest, looks good from a quick glance |
|
Cool, I'll merge if this build passes |
| result['_right_indicator']), | ||
| categories=[1, 2, 3]) | ||
| result[self.indicator_name] = ( | ||
| result[self.indicator_name] |
There was a problem hiding this comment.
I personally find this formatting very hard to read (though not real sure what's better)
There was a problem hiding this comment.
A lot of these formatting issues stem from statements that are too dense. result[self.indicator_name] should be a temporary variable here, as should perhaps the list of new categories
|
lgtm |
No description provided.