CLN: fix all flake8 warnings in pandas/tseries #12075
Conversation
| @@ -26,7 +25,7 @@ def strftime(self, date_format): | |||
| Return an array of formatted strings specified by date_format, which | |||
| supports the same string format as the python standard library. Details | |||
| of the string format can be found in the `python string format doc | |||
| <https://docs.python.org/2/library/datetime.html#strftime-and-strptime-behavior>`__ | |||
| https://docs.python.org/2/library/datetime.html. | |||
There was a problem hiding this comment.
This will give an error with Sphinx, as you left in the opening ```.
But I personally also find the original link better.
There was a problem hiding this comment.
This is hard, because there's no easy way (AFAICT, manual string concatenation is all I could think of) to keep the RST valid while also suppressing the flake8 warning. I fixed the broken markup for now. I've always felt that docstrings should be optimized for console use, and that more complex documentation should be in the docs themselves, but it's not a big deal either way
There was a problem hiding this comment.
Well, this is a case where 'A Foolish Consistency is the Hobgoblin of Little Minds' would apply I think, but the problem is that a #noqa does not really work in a docstring .. (for the sphinx output at least)
|
Looks good from a quick glance! (and for the diffs I could see) |
|
Cool, I can merge after Travis passes if we're all good |
|
If someone can +1 this and also review #12082 I can merge both of those |
|
I fixed it! |
| @@ -35,6 +35,7 @@ class TimeGrouper(Grouper): | |||
| Use begin, end, nperiods to generate intervals that cannot be derived | |||
| directly from the associated object | |||
There was a problem hiding this comment.
if you wouldn't mind removing tseries/resample.py from this patch as I mostly rewritten this file in #11841 (I will PEP that itself).
|
lgtm otherwise |
|
@jreback I nixed the resample.py diff, will merge when the build passes |
|
Cherry-picked in 1acdb31 |
|
merge away |
No description provided.