Skip to content

DOC: warnings and remove HTML #11660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 20, 2015

Conversation

TomAugspurger
Copy link
Contributor

Couple comments in #11610 (comment)

  • warning in the whatsnew
  • warning in the Styler docstring
  • removes generated HTML version of the notebook, that's built as part of the doc build.

Building the docs now to double check, I'll merge when those are good.

@jorisvandenbossche
Copy link
Member

Looks good!

TomAugspurger pushed a commit that referenced this pull request Nov 20, 2015
@TomAugspurger TomAugspurger merged commit d7dd136 into pandas-dev:master Nov 20, 2015
@TomAugspurger TomAugspurger mentioned this pull request Nov 20, 2015
@jreback jreback added the Docs label Nov 20, 2015
@jreback jreback added this to the 0.17.1 milestone Nov 20, 2015
@jreback
Copy link
Contributor

jreback commented Nov 20, 2015

@jorisvandenbossche IIRC we have ipython as a requirement of the doc-builds, should also add ipython-notebook (or jupyter)

@jorisvandenbossche
Copy link
Member

in principle, it's not ipython notebook, but just ipython for <4 (nbconvert it included, so that is OK) or nbconvert for >= 4

@jorisvandenbossche
Copy link
Member

But maybe safer to use ipython nbconvert instead of jupyter nbcnvert in make.py (as the first one works for all versions, the jupyter one only for the more recent)

@jorisvandenbossche
Copy link
Member

@TomAugspurger did you also check the api docs for the new styler if they render work correctly?

@TomAugspurger
Copy link
Contributor Author

Yep, the warning shows up there, things look good. I can upload the generated version somewhere if you want.

@TomAugspurger
Copy link
Contributor Author

Ahh, shoot found one mistake. I forgot to change Styler.set to Styler.use in api.rst. Is it easiest for you to change that?

@TomAugspurger
Copy link
Contributor Author

This is line 1713 in the current version of master, not sure how to link to it since GH renders the rst. Styler.set -> Styler.use

@jorisvandenbossche
Copy link
Member

no, you can go ahead and change it (I still have to switch from windows to linux for the final build)

@TomAugspurger TomAugspurger deleted the whatsnew-prov branch November 3, 2016 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants