-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DOC: warnings and remove HTML #11660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Looks good! |
41e6845
to
215fac4
Compare
215fac4
to
d805af3
Compare
DOC: warnings and remove HTML
@jorisvandenbossche IIRC we have |
in principle, it's not |
But maybe safer to use |
@TomAugspurger did you also check the api docs for the new styler if they render work correctly? |
Yep, the warning shows up there, things look good. I can upload the generated version somewhere if you want. |
Ahh, shoot found one mistake. I forgot to change |
This is line 1713 in the current version of master, not sure how to link to it since GH renders the rst. |
no, you can go ahead and change it (I still have to switch from windows to linux for the final build) |
Couple comments in #11610 (comment)
Building the docs now to double check, I'll merge when those are good.