Skip to content

RLS: 0.17.1 #11566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jreback opened this issue Nov 10, 2015 · 18 comments
Closed

RLS: 0.17.1 #11566

jreback opened this issue Nov 10, 2015 · 18 comments
Labels
Milestone

Comments

@jreback
Copy link
Contributor

jreback commented Nov 10, 2015

looking to do this on around Nov 20th (next friday)

@jreback jreback added this to the 0.17.1 milestone Nov 10, 2015
@jorisvandenbossche
Copy link
Member

Sounds good!

@jreback
Copy link
Contributor Author

jreback commented Nov 20, 2015

so going to tag shortly.

@jorisvandenbossche if you'd build/upload docs would be awesome. lmk when ready.

@jorisvandenbossche
Copy link
Member

yep, currently checking if there are still some doc issues with latest master

@jreback
Copy link
Contributor Author

jreback commented Nov 20, 2015

ok will wait for @TomAugspurger good to go
on styling and ok from you

@TomAugspurger
Copy link
Contributor

@jorisvandenbossche do you have jupyter nbconvert installed? I haven't documented that anywhere, but that's what is used for the notebook -> html.

I hope that's not messing anything up with the doc build. I'm seeing a lot more output than I recall, but I haven't built the full API docs in a while.

@jorisvandenbossche
Copy link
Member

yes, that is no problem. We should just update the doc building docs sometime

The doc build has grown a lot over the last years :-) (seeing a lot of output is normal, but you should be able to see the difference between normal output and errors/warnings)

@TomAugspurger
Copy link
Contributor

Ok #11660 is merged. I changed the wording in a couple places after you looked at it Joris FYI.

@jorisvandenbossche
Copy link
Member

@jreback You can tag after merging #11663 I think. I will only be able to build the docs later this evening or tomorrow morning (but it takes some time untill all artifacts are produced to be able to do the announcement anyway I think?)

@jreback
Copy link
Contributor Author

jreback commented Nov 20, 2015

@jorisvandenbossche yeh totally cool.

I'll tag after you merge that. Just won't send the announcement till docs are up.

@jreback
Copy link
Contributor Author

jreback commented Nov 20, 2015

ok, tagged and released on github. https://github.com/pydata/pandas/releases/tag/v0.17.1

will put on pypi / conda soon.

@jorisvandenbossche when builds are up, then links should be good & I will send out announcement & close this issue.

thanks everyone for making v0.17.1!

@TomAugspurger
Copy link
Contributor

@jreback right now http://pandas.pydata.org/pandas-docs/version/0.17.1/whatsnew.html#whatsnew-style doesn't have CSS. Looks like I messed something up? Will look in a bit.

EDIT: oh, or is that just because the docs aren't uploaded yet? I panicked a bit too quickly there :)

@jorisvandenbossche
Copy link
Member

yep, indeed, for some reason it does not give an error, but such a strange non-styled page if the version is not correctly specified

@jorisvandenbossche
Copy link
Member

docs are up!

@TomAugspurger
Copy link
Contributor

Thanks!

On Nov 21, 2015, at 01:36, Joris Van den Bossche [email protected] wrote:

docs are up!


Reply to this email directly or view it on GitHub.

@jreback
Copy link
Contributor Author

jreback commented Nov 21, 2015

thanks everyone!

@jreback jreback closed this as completed Nov 21, 2015
@TomAugspurger
Copy link
Contributor

@jorisvandenbossche do you know if we need to do any redirection of links from the pandas.pydata.org website?

http://pandas.pydata.org/pandas-docs/stable/style.html is different from
http://pandas.pydata.org/pandas-docs/version/0.17.1/style.html. The first one doesn't seem to have the CSS changes I made.

@jorisvandenbossche
Copy link
Member

@TomAugspurger for me (on Firefox), they both look the same (and not really 'pretty', but I thought it was like this, also the travis docs look like that for me)

@TomAugspurger
Copy link
Contributor

Looks like my browser was caching it. I reset that and things look good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants