interpreting index name in min_itemsize specification #11364, #10381

[DSLituiev]

closes #10381

The fix replaces named index columns in Table.index_axes with their names and corrects min_itemsize if it contains 'index' item which is not in Table.index_axes

[jreback]

you need to craft a test along the lines of the tests in pandas/io/tests/test_pytables.py

[jreback]

this is where to make the change: https://github.com/pydata/pandas/blob/master/pandas/io/pytables.py#L3248

[DSLituiev]

I updated the test, but sorry I do not see how to handle it by changing https://github.com/pydata/pandas/blob/master/pandas/io/pytables.py#L3248 as it works on data_columns and the issue concerns the index columns.

[jreback]

tests should be actually in test_pytables.py

and just slot into the existing infrastructure
you are reinventing the wheel

[DSLituiev]

I am sorry to admit I am unfamiliar with your infrastructure and conventions. I am not a professional software developer and it is first time I am trying it. Does it need to come in a special place? Anyway, I do not get your idea with implementation.

[jreback]

guidlines are here

no worries. just trying to help / get people to contribute.

[jreback]

closing, but if you'd like to update, pls reopen

[DSLituiev]

No problem. I anyway did not get how you want it to be solved.
As I wrote https://github.com/pydata/pandas/blob/master/pandas/io/pytables.py#L3248 works on data_columns and the issue concerns the index columns.

[jreback]

I think the references get moved. (as the file was updated). no worries. I was looking for a general fix ,rather than special casing here.