Add support for math functions in eval() #10953
Merged
+212
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
added
Enhancement
API Design
Numeric Operations
|
looks good. can you add a whatsnew note in 0.17.0 docs. pls squash as well. ping when green. |
| @@ -38,6 +38,7 @@ Highlights include: | |||
| - Development installed versions of pandas will now have ``PEP440`` compliant version strings (:issue:`9518`) | |||
| - Support for reading SAS xport files, see :ref:`here <whatsnew_0170.enhancements.sas_xport>` | |||
| - Removal of the automatic TimeSeries broadcasting, deprecated since 0.8.0, see :ref:`here <whatsnew_0170.prior_deprecations>` | |||
| - Support for math functions in .eval(), see :ref:`here <whatsnew_0170.matheval>` | |||
There was a problem hiding this comment.
pls add the issue number here as well.
There was a problem hiding this comment.
pls move to the Enhancements section
|
once I merged this: #10975 (or you can rebase on top) pls update the tests as you indicated |
| self.check_result_type(np.int64, np.float64) | ||
| self.check_result_type(np.float32, np.float32) | ||
| self.check_result_type(np.float64, np.float64) | ||
| # Did not test complex64 because DataFrame is converting it to |
There was a problem hiding this comment.
I merged the fix for #10952. if you'd add this test, would be great. ping when green.
|
@sklam can you update the tests |
|
@sklam can you update |
|
hmm, it appears |
jreback
added a commit
that referenced
this pull request
Sep 5, 2015
Add support for math functions in eval()
|
thanks @sklam |
sinhrks
added a commit
that referenced
this pull request
Sep 14, 2015
DOC: Update "enhancing perf" doc based on #10953
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #4893
Extends the eval parser to accept calling math functions.