-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
BUG: rplot.GeomDensity2D flips axes #3753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@flo-rian do you want to submit a pr for this? |
No, I am new to github and tried to quickly do that but it seems too Thanks, On 07/21/2013 02:07 AM, Phillip Cloud wrote:
|
@flo-rian if u have the fix on github i can pull down, do whatever git surgery needs to be done and put it in the codebase for you 😄 all the while retaining authorship |
i see that the fix could be just transposition but are you sure that doesn't break anything else? seemingly trivial things can break other things in a non trivial way. in this case you're probably right, but it's good to be sure |
Dear Phillip, thanks for the 'github surgery offer' :-) Regarding the breaking things: I just transpose the Z array that is fed Regards, Florian class GeomDensity2D(Layer): Parameters:fig: matplotlib figure object Returns:fig, ax: matplotlib figure and axis objects Am 22.7.2013 03:48, schrieb Phillip Cloud:
|
@flo-rian doing a PR on this? |
xref #3445 |
The axes drawn by rplot.GeomDensity2D are flipped.
line 565 reads:
ax.contour(Z, extent=[x_min, x_max, y_min, y_max])
but should read:
ax.contour(Z.T, extent=[x_min, x_max, y_min, y_max])
The following test code gives the results shown below:
The text was updated successfully, but these errors were encountered: