Skip to content

Deprecating the trellis rplot module #3445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ghost opened this issue Apr 24, 2013 · 19 comments · Fixed by #9357
Closed

Deprecating the trellis rplot module #3445

ghost opened this issue Apr 24, 2013 · 19 comments · Fixed by #9357
Labels
Milestone

Comments

@ghost
Copy link

ghost commented Apr 24, 2013

Original title: rplot.rst needs cleaning up


http://pandas.pydata.org/pandas-docs/dev/rplot.html

plot style, dimensions, grids, legend.

@jreback
Copy link
Contributor

jreback commented Sep 22, 2013

@cpcloud doc-man?

@cpcloud
Copy link
Member

cpcloud commented Sep 22, 2013

Sure! Good a time as any to learn this dark corner of pandas :)

@ghost ghost assigned cpcloud Sep 22, 2013
@cpcloud
Copy link
Member

cpcloud commented Dec 14, 2013

I'll clean this up, but IMHO I think the rplot functionality should be deprecated in the next major release of pandas (1.0). Nobody really maintains this. The paucity of issues about rplot suggests that this doesn't see much use in the wild either. Just my 2c.

@jtratner @jreback @y-p thoughts?

@jtratner
Copy link
Contributor

rplot is really useful (and I ported it back to an earlier release because I wanted to use it for a project) but it's slow, somewhat visually unappealing, and (at least for me) hard to figure out how to tweak.

What if we split off visualization into a separate library that pandas would keep as a dep (i.e., the plotting module would provide plot() and allied methods)? We could then have a separate set of maintainers take primary responsibility for that module (and be able to more easily bring in the kinds of things that @olgabot, @TomAugspurger and I believe @JanSchulz have worked on on and off).

Alternatively, I get the sense that rplot was trying to bring in some of the concepts that the ggplot port would now cover, so maybe we could bring it in that way.

@jtratner
Copy link
Contributor

or even if we didn't split it off, just give a few people the responsibility for focusing on pandas visualizations and emphasizing making them look good.

@jankatins
Copy link
Contributor

I think it would make sense to split most of the plotting (from pandas and statsmodels) off into two projects (one ggplot-codeing-style like, one matplotlib-coding-style like). There are currently so many (matplotlib-based and otherwise -> JS, d3,...) python plotting libs showing up, it looks like some consolidation would be nice to not waste so much effort...

@jtratner
Copy link
Contributor

Plus right now you can drop in rplot as far back as 0.11 and it'll work, so
already seems like viz isn't strongly tied into pandas internals.

@ghost
Copy link
Author

ghost commented Dec 15, 2013

ggplot2 does indeed have very strong support for faceting so if this was available elsewhere rplot is
somewhat redundant.

Anyway, as I said elsewhere, my view is that pandas shouldn't focus on viz if a suitable alternative emerges.
That wasn't the case 2-3 years ago but things may be slowly changing. Viz is certainly important enough
to have it's own space.

@jtratner
Copy link
Contributor

I looked around, there a bunch of libraries at this point, many of which use pandas internally (e.g., seaborn) so I don't really think it makes sense to go start something new. It would be nice to standardize on one or two though.

@jorisvandenbossche
Copy link
Member

Coming back to this older thread (as there was a discussion on the docs of it in #8351): I think it is a good time to reconsider the status of the trellis plotting interface in pandas (tools/rplot.py) and the arguments made above:

  • as @cpcloud mentions above, nobody really maintains or enhances this. And hasn't changed the last year since that comment (https://github.com/pydata/pandas/commits/master/pandas/tools/rplot.py). While there are some open issues with bugs about this.
  • above there was spoken about splitting it off in seperate projects (eg a ggplot-like one). In the meantime, I think, these projects have already emerged, most notably in python-ggplot and seaborn I think (among probably others)

So: would deprecating the trellis rplot interface in pandas make sense?

@orbitfold You are the original author of this I think. What is your opinion on this?
@jtratner @JanSchulz

As proposed by @TomAugspurger in #8351, we could make a doc section showing for each example of the current pandas trellis interface, how to do the equivalent using python-ggplot and/or seaborn for easy transitioning.

@jankatins
Copy link
Contributor

I think you summed up the current situation pretty well: seaborn has trellis plots and it seems that much of the work on "matplotlib style higher plotting functions" is going into that library.

As someone looked into how much this interface is actually used? SO?

@jorisvandenbossche
Copy link
Member

SO search on "[pandas] rplot" gives one question (and one answer to another question): http://stackoverflow.com/search?q=[pandas]+rplot (and other similar searches did no yield more)

@jreback
Copy link
Contributor

jreback commented Jan 26, 2015

older thread but anybody for killing trellis plotting in 0.16.0 and just pointing to seaborn?

@TomAugspurger
Copy link
Contributor

We should at least start warning / deprecating.

@jreback
Copy link
Contributor

jreback commented Jan 26, 2015

yes let's do that at least (maybe a nice box at the top of the section)

@jorisvandenbossche
Copy link
Member

@TomAugspurger Did you already have some examples of how to do it in seaborn? I vaguely can remember you posted it once in an issue?
@JanSchulz would you be interested in giving some examples of ggplot? So basically for some of the current examples, just give the exact equivalent in ggplot

@jorisvandenbossche jorisvandenbossche changed the title rplot.rst needs cleaning up Deprecating the trellis rplot module Jan 26, 2015
@jorisvandenbossche
Copy link
Member

Started with a deprecation warning in #9357

@jankatins
Copy link
Contributor

@jorisvandenbossche I've added a bugreport in ggplot, but I think currently we are nto ready yet (faceting and categorical are not so nice in ggplot currently ...)

@jorisvandenbossche
Copy link
Member

Closed by #9357

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants