Skip to content

DataFrame.add with fill_value bug #2191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wesm opened this issue Nov 7, 2012 · 3 comments
Closed

DataFrame.add with fill_value bug #2191

wesm opened this issue Nov 7, 2012 · 3 comments
Labels
Bug
Milestone
0.9.1

Comments

@wesm
Copy link
Member

wesm commented Nov 7, 2012

Very, very surprised this bug isn't caught by the test suite.

df1 = pandas.DataFrame({'a':{True:1,False:5},'b':{True:7,False:8}})
df2 = pandas.DataFrame({'a':{True:1,False:5},'c':{True:7,False:8}})

In [15]: df1.add(df2, fill_value=0)
Out[15]: 
        a   b   c
False  10 NaN NaN
True    2 NaN NaN
changhiskhan added a commit that referenced this issue Nov 7, 2012
@changhiskhan
BUG: fill_value not being applied for mixed type frame #2191
5c945e1
@changhiskhan
Copy link
Contributor

the joining turns it into a mixed type frame. The test that checks combineAdd was already float. The test that checks mixed type did not have differing columns.

@wesm
Copy link
Member Author

wesm commented Nov 7, 2012

crapola =/ figured it was something like that related to dtypes

@changhiskhan
Copy link
Contributor

via 5c945e1

yarikoptic added a commit to neurodebian/pandas that referenced this issue Nov 15, 2012
@yarikoptic
Merge commit 'v0.9.0-169-g5c945e1' into debian
726a8b9 
* commit 'v0.9.0-169-g5c945e1':
  BUG: fill_value not being applied for mixed type frame pandas-dev#2191
  BUG: bug in setup.py with cython and sdist command class pandas-dev#2188
  BLD: c scope decl wrong
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
0.9.1
Development

No branches or pull requests
2 participants
@wesm @changhiskhan