-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DateFrame.truncate is not equivalent to slicing as mentioned in docs #17763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
The docstring can indeed use some love (and examples). PR's welcome. That said, we could also question the need for this function. Is it that useful given you can do the same with indexing? (if you are aware of the difference in how the labels are interpreted) Just as a question (I never use it myself), do you use this function a lot? And if so, would it be hard to convert to using slicing? |
I've never used it and it seems to rarely come up on stackoverflow. I suppose it could be useful to add parameters include_start and include_end like At a more macro-scale, I find it strange that there are several DataFrame/Series methods that only work with DatetimeIndex - The naming of some of these methods is completely non-intuitive. Especially something like It would take a major break in API to refactor these methods out somewhere else. |
Code Sample, a copy-pastable example if possible
Problem description
The documentation for
truncate
has misleading information.truncate
and slicing are not the same. Slicing returns all partially matching dates while truncate stops at an exact datetime - it assumes 0's for any unspecified date component.Also, truncate can take datetime and partial string datetimes which, to me, isn't apparent in the docstrings.
Expected Output
Output of
pd.show_versions()
INSTALLED VERSIONS
commit: None
python: 3.6.1.final.0
python-bits: 64
OS: Darwin
OS-release: 15.6.0
machine: x86_64
processor: i386
byteorder: little
LC_ALL: None
LANG: en_US.UTF-8
LOCALE: en_US.UTF-8
pandas: 0.20.3
pytest: 3.0.7
pip: 9.0.1
setuptools: 35.0.2
Cython: 0.25.2
numpy: 1.13.1
scipy: 0.19.0
xarray: None
IPython: 6.0.0
sphinx: 1.5.5
patsy: 0.4.1
dateutil: 2.6.1
pytz: 2017.2
blosc: None
bottleneck: 1.2.0
tables: 3.4.2
numexpr: 2.6.2
feather: None
matplotlib: 2.0.2
openpyxl: 2.4.7
xlrd: 1.0.0
xlwt: 1.2.0
xlsxwriter: 0.9.6
lxml: 3.7.3
bs4: 4.6.0
html5lib: 0.9999999
sqlalchemy: 1.1.9
pymysql: None
psycopg2: None
jinja2: 2.9.6
s3fs: None
pandas_gbq: None
pandas_datareader: 0.3.0.post
The text was updated successfully, but these errors were encountered: