Skip to content

API: add encoding for to_json() #13774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jreback opened this issue Jul 24, 2016 · 4 comments
Closed

API: add encoding for to_json() #13774

jreback opened this issue Jul 24, 2016 · 4 comments
Labels
API Design Enhancement IO JSON read_json, to_json, json_normalize Unicode Unicode strings

Comments

@jreback
Copy link
Contributor

jreback commented Jul 24, 2016 •
edited
Loading

xref #13351

Here's the test, currently skipped
@jreback jreback added this to the Next Major Release milestone Jul 24, 2016
jreback added a commit that referenced this issue Jul 24, 2016
@jreback
TST: skip .to_json with encoding test as not implemented yet
964b7bb 
xref #13351
xref #13774
@aterrel aterrel self-assigned this Jul 24, 2016
@jorisvandenbossche jorisvandenbossche modified the milestones: 0.19.0, Next Major Release Jul 24, 2016
@jorisvandenbossche
Copy link
Member

@aterrel Interested in doing this one?

@aterrel
Copy link
Contributor

aterrel commented Aug 31, 2016

Yeah, I've been a bit of of pocket but I'll check it out this weekend

@jreback jreback modified the milestones: 0.20.0, 0.19.0 Aug 31, 2016
@jreback jreback mentioned this issue Mar 17, 2017
Closed
@jreback jreback modified the milestones: 0.20.0, Next Major Release Mar 23, 2017
@jreback jreback mentioned this issue Apr 4, 2018
Closed
@jbrockmendel jbrockmendel added the IO JSON read_json, to_json, json_normalize label Jul 25, 2018
@WillAyd WillAyd mentioned this issue Mar 11, 2020
Merged
@WillAyd
Copy link
Member

WillAyd commented Mar 11, 2020

Outside of "closed systems" I think there is an established internet standard for JSON to be UTF-8. See section 8.1 in:

https://www.rfc-editor.org/info/rfc8259

Worth closing at this point?

@mroeschke
Copy link
Member

Will brings up a good point in addition to not much traction on this enhancement request, closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
API Design Enhancement IO JSON read_json, to_json, json_normalize Unicode Unicode strings
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@aterrel @WillAyd @jreback @jorisvandenbossche @jbrockmendel @mroeschke