-
-
Notifications
You must be signed in to change notification settings - Fork 141
fix signature of frame.filter #964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a test that fails without your PR and works with your PR?
Allready started (great minds and such) |
CI is failing because pyright got upgraded and we have to remove some |
This is now merged, so go ahead and merge with |
items can be ListLike
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @refack
Keep up the great work |
@Dr-Irv apropos, I just stumbled on pandas-dev/pandas#47215 |
items
can beListLike
It is turned into and
Index
which can handle andListLike
as datahttps://github.com/pandas-dev/pandas/blob/9b375be5aa3610e8a21ef0b5b81e4db04270f3d3/pandas/core/generic.py#L5448
assert_type()
to assert the type of any return value