Skip to content

Commit 2c62dc3

Browse files
committed
Type can be even more loose
1 parent 60e3abc commit 2c62dc3

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

pandas-stubs/core/frame.pyi

+1-1
Original file line numberDiff line numberDiff line change
@@ -1711,7 +1711,7 @@ class DataFrame(NDFrame, OpsMixin):
17111711
) -> DataFrame: ...
17121712
def filter(
17131713
self,
1714-
items: ListLike | None = ...,
1714+
items: Iterable | None = ...,
17151715
like: _str | None = ...,
17161716
regex: _str | None = ...,
17171717
axis: Axis | None = ...,

tests/test_frame.py

+4
Original file line numberDiff line numberDiff line change
@@ -319,6 +319,10 @@ def test_types_filter() -> None:
319319
df.filter(items=["col1"])
320320
df.filter(regex="co.*")
321321
df.filter(like="1")
322+
# [PR 964] any Iterable should work since internally it's converted to an Index
323+
df.filter(items={"col2", "col2", "col2"})
324+
df.filter(items=("col2", "col2", 1, tuple([4])))
325+
df.filter(items=("col2" for _ in range(3)))
322326

323327

324328
def test_types_setting() -> None:

0 commit comments

Comments
 (0)