fix nightly build with Series.to_numpy() on a Timedelta series #500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twoertwein
reviewed
Jan 7, 2023
tests/test_timefuncs.py
Outdated
| check(assert_type(td_s.to_numpy(na_value=0), np.ndarray), np.ndarray) | ||
| else: | ||
| check( | ||
| assert_type(td_s.to_numpy(na_value=pd.Timedelta(0)), np.ndarray), np.ndarray |
There was a problem hiding this comment.
Can we always use the else case?
There was a problem hiding this comment.
Can we always use the
elsecase?
I tried that, and it didn't work, but now I tried again, and it did work! Must have done something wrong the first time.
Fixed in commit #c93d157
twoertwein
approved these changes
Jan 7, 2023
|
Thanks @Dr-Irv ! |
twoertwein
pushed a commit
to twoertwein/pandas-stubs
that referenced
this pull request
Apr 1, 2023
…s-dev#500) * fix nightly build with Series.to_numpy() on a Timedelta series * just use Timedelta(0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just made the test depend on the pandas version
Either @twoertwein or @bashtage can review, approve or merge. Both approvals not needed.