Skip to content

nightly failing due to timedelta and NA values #499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Dr-Irv opened this issue Jan 6, 2023 · 1 comment · Fixed by #500
Closed

nightly failing due to timedelta and NA values #499

Dr-Irv opened this issue Jan 6, 2023 · 1 comment · Fixed by #500
Labels
good first issue

Comments

@Dr-Irv
Copy link
Collaborator

Dr-Irv commented Jan 6, 2023 •
edited
Loading

Nightly failing due to restriction on to_numpy() values for na_value

In test_timefuncs.py, we have this test:

check(assert_type(td_s.to_numpy(na_value=0), np.ndarray), np.ndarray)

Need to change it to

check(assert_type(td_s.to_numpy(na_value=pd.Timedelta(0)), np.ndarray), np.ndarray)
@bashtage
Copy link
Contributor

bashtage commented Jan 6, 2023

The definitions probably also adjustment since looks like int is not allowed.

@Dr-Irv Dr-Irv mentioned this issue Jan 7, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix nightly build with Series.to_numpy() on a Timedelta series Dr-Irv/pandas-stubs
2 participants
@bashtage @Dr-Irv