feat: add table to JsonSeriesOrient Literals
#482
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twoertwein
reviewed
Dec 22, 2022
| @@ -318,7 +318,7 @@ MergeHow: TypeAlias = Union[JoinHow, Literal["cross"]] | |||
| JsonFrameOrient: TypeAlias = Literal[ | |||
| "split", "records", "index", "columns", "values", "table" | |||
| ] | |||
| JsonSeriesOrient: TypeAlias = Literal["split", "records", "index"] | |||
| JsonSeriesOrient: TypeAlias = Literal["split", "records", "index", "table"] | |||
There was a problem hiding this comment.
There seem to be a few more orientation values https://pandas.pydata.org/pandas-docs/stable/reference/api/pandas.DataFrame.to_json.html that can be added.
Ideally, we would also have a test for this.
Dr-Irv
requested changes
Dec 23, 2022
|
Commit A more general question - can we not import types from pandas-stubs directly? With |
DarioHett
requested review from
Dr-Irv and
twoertwein
and removed request for
Dr-Irv and
twoertwein
twoertwein
reviewed
Dec 24, 2022
twoertwein
reviewed
Dec 24, 2022
tests/test_io.py
Outdated
| @@ -387,12 +387,39 @@ def test_json(): | |||
| check(assert_type(read_json(bin_json), DataFrame), DataFrame) | |||
|
|
|||
|
|
|||
| def test_json_series(): | |||
| def test_json_series(orient): | |||
There was a problem hiding this comment.
Is the orient argument of test_json_series unused?
Dr-Irv
requested changes
Dec 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes the Literal
tablefor theorientargument in s.to_json().