Skip to content

Missing values in JsonSeriesOrient #458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DaveMDS opened this issue Dec 4, 2022 · 4 comments
Closed

Missing values in JsonSeriesOrient #458

DaveMDS opened this issue Dec 4, 2022 · 4 comments

Comments

@DaveMDS
Copy link

DaveMDS commented Dec 4, 2022

hi guys,
JsonSeriesOrient in _typing.py is missing two values, namely table and values

it should be:
JsonSeriesOrient: TypeAlias = Literal["split", "records", "index", "table", "values"]

values is also missing in panda docs, but I tested both on pandas 1.5.1 and they work as expected

Can they be added? forking and making a pr seems a bit overkill for this task ;)

Thanks in advance
DaveMDS

@bashtage
Copy link
Contributor

bashtage commented Dec 4, 2022

We try not to add things that aren't documented. The process to fix this would be:

  1. Open a PR with pandas with the doc fix.
  2. Open a PR here with the typing fix.

@ramvikrams
Copy link
Contributor

@bashtage should I open the issue in pandas and open the pr here

@Dr-Irv
Copy link
Collaborator

Dr-Irv commented Dec 28, 2022

Closing this. values is not documented. When documented, can re-open the issue. table was fixed in #482

@Dr-Irv Dr-Irv closed this as completed Dec 28, 2022
@DaveMDS
Copy link
Author

DaveMDS commented Jan 11, 2023

Thanks !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants