-
-
Notifications
You must be signed in to change notification settings - Fork 141
Missing values in JsonSeriesOrient #458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
We try not to add things that aren't documented. The process to fix this would be:
|
@bashtage should I open the issue in pandas and open the pr here |
1 task
Closing this. |
Thanks !! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
hi guys,
JsonSeriesOrient
in _typing.py is missing two values, namelytable
andvalues
it should be:
JsonSeriesOrient: TypeAlias = Literal["split", "records", "index", "table", "values"]
values
is also missing in panda docs, but I tested both on pandas 1.5.1 and they work as expectedCan they be added? forking and making a pr seems a bit overkill for this task ;)
Thanks in advance
DaveMDS
The text was updated successfully, but these errors were encountered: