for gh-468 #477
for gh-468 #477
Conversation
There was a problem hiding this comment.
I don't think we want to use a decorator on top of a test function, but rather have something that lets us skip running a particular line of code based on the version so that we can keep the offending lines rather isolated.
So, for example, this test in test_scalars.py is failing:
check(assert_type(p + offset_index, pd.PeriodIndex), pd.PeriodIndex)It is failing because in the future the result will be a pd.Index. So we will leave the typing alone, but need to change what is passed to check() based on the version number.
Other tests are changing because of date/time parsing, in which case the warnings have to be checked based on the version number.
| @@ -136,3 +136,21 @@ def pytest_warns_bounded( | |||
| return nullcontext() | |||
| else: | |||
| return suppress(upper_exception) | |||
|
|
|||
|
|
|||
| def nigthly_test_skip( | |||
What is to be done is check a test on the version speicifed and check other test normally, have I understood it correctly |
Do the test as it is now if the version is 1.5.x, and use the new result if the version is later than that. Also have to deal with the datetime failures, since that warning has changed. |
|
closing in favor of #485 |
assert_type()to assert the type of any return valuewanted some discussion about what could the return type for the func