Skip to content

nightly failing - possibly due to pandas bug #468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Dr-Irv opened this issue Dec 10, 2022 · 3 comments · Fixed by #485
Closed

nightly failing - possibly due to pandas bug #468

Dr-Irv opened this issue Dec 10, 2022 · 3 comments · Fixed by #485

Comments

@Dr-Irv
Copy link
Collaborator

Dr-Irv commented Dec 10, 2022

nightly is failing due to arithmetic between offsets and period index changing result.

So either we see if that gets fixed, or change our tests.

See pandas-dev/pandas#50162

@ramvikrams
Copy link
Contributor

Sir should we modify our tests or should wait for him to reply in the pandas issue.

@Dr-Irv
Copy link
Collaborator Author

Dr-Irv commented Dec 19, 2022

We have to modify the tests, based on a discussion during the pandas development meeting.

Should build a function similar to pytest_warns_bounded that allows us to skip the test at runtime if the pandas version is greater than a passed value, and then use it in appropriate places where nightly is failing.

@ramvikrams
Copy link
Contributor

ramvikrams commented Dec 19, 2022

We have to modify the tests, based on a discussion during the pandas development meeting.

Should build a function similar to pytest_warns_bounded that allows us to skip the test at runtime if the pandas version is greater than a passed value, and then use it in appropriate places where nightly is failing.

thanks sir, I'll do it

@ramvikrams ramvikrams mentioned this issue Dec 19, 2022
2 tasks
@Dr-Irv Dr-Irv mentioned this issue Dec 28, 2022
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants