Follow up PR for changes requested in #445 #451
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
assert_type()
to assert the type of any return valueFollow up PR for #445
Added the two value_counts method as told, tried to change the tests but I have some questions here:-
check(assert_type(c1, pd.Series[int]), pd.Series, pd.Series[int])
it shows this error
Type application has too few types (2 expected) [misc]
it only works when we write the test likethis
check(assert_type(c1, pd.Series[int]), pd.Series)
type' object is not subscriptable
and only works when we write the test like
check(assert_type(c1, pd.Series), pd.Series)
butmypy
fails here it saysExpression is of type "Series[float]", not "Series[Any]" [assert-type]
Failed: DID NOT WARN. No warnings of type (<class 'FutureWarni...
while runningpoe pytest