Follow up PR for changes requested in #445 (#451)

* Follow up PR for changes requested in #445

* updated the test_frame.py by changing the assert-type and adding the second check type

Author: ramvikrams

pandas-stubs/core/groupby/generic.pyi

@@ -65,14 +65,24 @@ class SeriesGroupBy(GroupBy, Generic[S1]):
     def filter(self, func, dropna: bool = ..., *args, **kwargs): ...
     def nunique(self, dropna: bool = ...) -> Series: ...
     def describe(self, **kwargs) -> DataFrame: ...
+    @overload
     def value_counts(
         self,
-        normalize: Literal[False, True] = ...,
+        normalize: Literal[False] = ...,
         sort: bool = ...,
         ascending: bool = ...,
         bins=...,
         dropna: bool = ...,
-    ) -> Series: ...
+    ) -> Series[int]: ...
+    @overload
+    def value_counts(
+        self,
+        normalize: Literal[True],
+        sort: bool = ...,
+        ascending: bool = ...,
+        bins=...,
+        dropna: bool = ...,
+    ) -> Series[float]: ...
     def count(self) -> Series[int]: ...
     def pct_change(
         self,

tests/test_frame.py

@@ -2040,8 +2040,10 @@ def test_series_groupby_and_value_counts() -> None:
             "Max Speed": [380, 370, 24, 26],
         }
     )
-    c: pd.Series = df.groupby("Animal")["Max Speed"].value_counts()
-    check(assert_type(c, pd.Series), pd.Series)
+    c1 = df.groupby("Animal")["Max Speed"].value_counts()
+    c2 = df.groupby("Animal")["Max Speed"].value_counts(normalize=True)
+    check(assert_type(c1, "pd.Series[int]"), pd.Series, int)
+    check(assert_type(c2, "pd.Series[float]"), pd.Series, float)
 
 
 def test_axes_as_tuple() -> None: