Skip to content

Type pivot arguments #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 28, 2022
Merged

Type pivot arguments #234

merged 1 commit into from
Aug 28, 2022

Conversation

phofl
Copy link
Member

@phofl phofl commented Aug 28, 2022

  • Closes #xxxx (Replace xxxx with the Github issue number)
  • Tests added: Please use assert_type() to assert the type of any return value

Just a general question: Can we type lib.NoDefault here?

Dr-Irv
Dr-Irv approved these changes Aug 28, 2022
View reviewed changes
Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @phofl

@Dr-Irv Dr-Irv merged commit fc3a5f3 into pandas-dev:main Aug 28, 2022
@phofl phofl deleted the pivot branch August 29, 2022 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dr-Irv Dr-Irv Dr-Irv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phofl @Dr-Irv