Skip to content

Commit fc3a5f3

Browse files
authored
Type pivot arguments (#234)
1 parent e284165 commit fc3a5f3

File tree

3 files changed

+26
-9
lines changed

3 files changed

+26
-9
lines changed

pandas-stubs/core/frame.pyi

+3-3
Original file line numberDiff line numberDiff line change
@@ -951,9 +951,9 @@ class DataFrame(NDFrame, OpsMixin):
951951
) -> _DataFrameGroupByNonScalar: ...
952952
def pivot(
953953
self,
954-
index=...,
955-
columns=...,
956-
values=...,
954+
index: IndexLabel = ...,
955+
columns: IndexLabel = ...,
956+
values: IndexLabel = ...,
957957
) -> DataFrame: ...
958958
def pivot_table(
959959
self,

pandas-stubs/core/reshape/pivot.pyi

+3-3
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,9 @@ def pivot_table(
2727
) -> DataFrame: ...
2828
def pivot(
2929
data: DataFrame,
30-
index: str | None = ...,
31-
columns: str | None = ...,
32-
values: IndexLabel | None = ...,
30+
index: IndexLabel = ...,
31+
columns: IndexLabel = ...,
32+
values: IndexLabel = ...,
3333
) -> DataFrame: ...
3434
def crosstab(
3535
index: Sequence | Series,

tests/test_frame.py

+20-3
Original file line numberDiff line numberDiff line change
@@ -543,9 +543,26 @@ def test_types_pivot() -> None:
543543
"col4": [100, 102, 500, 600],
544544
}
545545
)
546-
df.pivot(index="col1", columns="col3", values="col2")
547-
df.pivot(index="col1", columns="col3")
548-
df.pivot(index="col1", columns="col3", values=["col2", "col4"])
546+
check(
547+
assert_type(
548+
df.pivot(index="col1", columns="col3", values="col2"), pd.DataFrame
549+
),
550+
pd.DataFrame,
551+
)
552+
check(
553+
assert_type(df.pivot(index="col1", columns="col3"), pd.DataFrame), pd.DataFrame
554+
)
555+
check(
556+
assert_type(
557+
df.pivot(index="col1", columns="col3", values=["col2", "col4"]),
558+
pd.DataFrame,
559+
),
560+
pd.DataFrame,
561+
)
562+
check(assert_type(df.pivot(columns="col3"), pd.DataFrame), pd.DataFrame)
563+
check(
564+
assert_type(df.pivot(columns="col3", values="col2"), pd.DataFrame), pd.DataFrame
565+
)
549566

550567

551568
def test_types_groupby() -> None:

0 commit comments

Comments
 (0)