-
-
Notifications
You must be signed in to change notification settings - Fork 141
TYP: Series/DataFrame/Index are not Hashable #113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
829440d
TYP: Series/DataFrame are not Hashable
twoertwein 53bbb51
explicitly set __hash__ also in the sub-classes (they inherit from cl…
twoertwein 4d57f05
cover a few more __hash__; and try to check types at runtime
twoertwein 5ef1675
just in case it would affect static type checking
twoertwein 25b59a7
cache only poetry.lock
twoertwein 77fe1f0
remove runtime check
twoertwein 97535f1
assert assert_type
twoertwein 069094b
undo change for the runtype hack
twoertwein dc110fe
poetry.lock should not be dependent on the OS/python version
twoertwein b24c300
Empty commit
twoertwein f949971
move ClassVar to the top
twoertwein e61ae6f
negative type tests
twoertwein 5452279
move to top
twoertwein File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,6 +5,7 @@ import datetime as _dt | |
from typing import ( | ||
Any, | ||
Callable, | ||
ClassVar, | ||
Dict, | ||
Hashable, | ||
Iterable, | ||
|
@@ -183,6 +184,8 @@ class DataFrame(NDFrame, OpsMixin): | |
Index, | ||
Series, | ||
] | ||
__hash__: ClassVar[None] # type: ignore[assignment] | ||
|
||
def __new__( | ||
cls, | ||
data: Optional[Union[_ListLike, DataFrame, Dict[Any, Any]]] = ..., | ||
|
@@ -428,7 +431,7 @@ class DataFrame(NDFrame, OpsMixin): | |
*, | ||
axis: Axis = ..., | ||
index: Hashable | Sequence[Hashable] = ..., | ||
columns: Hashable | Sequence[Hashable] = ..., | ||
columns: Hashable | Sequence[Hashable] | Index = ..., | ||
level: Optional[Level] = ..., | ||
inplace: Literal[True], | ||
errors: IgnoreRaise = ..., | ||
|
@@ -440,7 +443,7 @@ class DataFrame(NDFrame, OpsMixin): | |
*, | ||
axis: Axis = ..., | ||
index: Hashable | Sequence[Hashable] = ..., | ||
columns: Hashable | Sequence[Hashable] = ..., | ||
columns: Hashable | Sequence[Hashable] | Index = ..., | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same as above. If |
||
level: Optional[Level] = ..., | ||
inplace: Literal[False] = ..., | ||
errors: IgnoreRaise = ..., | ||
|
@@ -452,7 +455,7 @@ class DataFrame(NDFrame, OpsMixin): | |
*, | ||
axis: Axis = ..., | ||
index: Hashable | Sequence[Hashable] = ..., | ||
columns: Hashable | Sequence[Hashable] = ..., | ||
columns: Hashable | Sequence[Hashable] | Index = ..., | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same as above. If |
||
level: Optional[Level] = ..., | ||
inplace: bool = ..., | ||
errors: IgnoreRaise = ..., | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
import typing_extensions | ||
import types | ||
|
||
|
||
def assert_type(actual_object, expected): | ||
# rough check whether the types might match | ||
|
||
actual = type(actual_object).__name__.split(".")[-1] | ||
error = False | ||
|
||
if isinstance(expected, types.GenericAlias): # type: ignore[attr-defined] | ||
expected = expected.__name__ | ||
|
||
if isinstance(expected, str): | ||
actual = actual.lower() | ||
expected = expected.lower() | ||
error = actual not in expected | ||
elif expected is None: | ||
error = actual_object is not None | ||
else: | ||
error = not isinstance(actual_object, expected) | ||
|
||
if error: | ||
raise TypeError(f"Expected '{expected}' got '{actual}'") | ||
|
||
|
||
typing_extensions.assert_type = assert_type | ||
twoertwein marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If
Index
is nowHashable
, do you need to change this?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Index
was declared to beHashable
but it isn't.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Index
probably needs to be added to many more annotations. Just added it here because a test was falling without it.