TYP: Series/DataFrame/Index are not Hashable

[twoertwein]

• relate to BUG: Overloads for accessing columns of a DataFrame are too restrictive #97
• Tests added: Please use assert_type() to assert the type of any return value

[twoertwein]

I cannot reproduce the dist failure of pyright:

poetry run poe install_dist
poetry run poe rename_src
poetry run poe pyright_dist  # no errors

[Dr-Irv]

I cannot reproduce the dist failure of pyright:

I looked in your log and saw this in the install_dist step:

pandas-stubs is already installed with the same version as the provided wheel. Use --force-reinstall to force an installation of the wheel.

So it may be that the caching you introduced is keeping around a version of pandas-stubs from a previous test??

[twoertwein]

So it may be that the caching you introduced is keeping around a version of pandas-stubs from a previous test??

Yes, that must be the case! Thank you for finding this! Let's just cache poetry.lock.

[Dr-Irv]

Yes, that must be the case! Thank you for finding this! Let's just cache poetry.lock.

MIght be a good idea to change build_dist to do a --force-reinstall

[Dr-Irv]

ping when you want me to review the whole thing (and it's all green)

[twoertwein]

Green and ready for review @Dr-Irv

Caching just poetry.lock seems to make the installation twice as fast while caching poetry.lock and the venv makes it three times as fast. I'm fine just caching poetry.lock.

[Dr-Irv]

If Index is now Hashable, do you need to change this?

[twoertwein]

Index was declared to be Hashable but it isn't.

[twoertwein]

Index probably needs to be added to many more annotations. Just added it here because a test was falling without it.

[Dr-Irv]

same as above. If Index is now Hashable, do you need to change this?

[Dr-Irv]

same as above. If Index is now Hashable, do you need to change this?

[Dr-Irv]

You could add a negative test to verify that these types are not Hashable, e.g.,

def test_not_hashable():
    def test_func(h: Hashable):
        pass
    test_func(pd.Series()) # type: ignore

[twoertwein]

You could add a negative test to verify that these types are not Hashable, e.g.,

Added and green

[Dr-Irv]

Thanks @twoertwein